ACK: [PATCH] src: Clean-up: remove trailing spaces and tabs from lines

Alex Hung alex.hung at canonical.com
Thu Nov 26 21:17:53 UTC 2020


On 2020-11-26 4:41 a.m., Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
> 
> Remove some trailing whitespaces from code. No functional change.
> 
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>  src/bios/bios_info/bios_info.c           | 2 +-
>  src/bios/ebda_region/ebda_region.c       | 2 +-
>  src/example/blank/blank.c                | 4 ++--
>  src/kernel/klog/klog.c                   | 2 +-
>  src/lib/src/fwts_interactive.c           | 2 +-
>  src/lib/src/fwts_ioport.c                | 2 +-
>  src/lib/src/fwts_oops.c                  | 2 +-
>  src/libfwtsacpica/fwts_acpica.c          | 2 +-
>  src/uefi/securebootcert/securebootcert.c | 2 +-
>  9 files changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/src/bios/bios_info/bios_info.c b/src/bios/bios_info/bios_info.c
> index c2de9f95..d1496885 100644
> --- a/src/bios/bios_info/bios_info.c
> +++ b/src/bios/bios_info/bios_info.c
> @@ -57,7 +57,7 @@ static int bios_info_test1(fwts_framework *fw)
>  
>  	for (i = 0; bios_info[i].dmi_field != NULL; i++) {
>  		char *data;
> -		snprintf(path, sizeof(path), "/sys/class/dmi/id/%s", 
> +		snprintf(path, sizeof(path), "/sys/class/dmi/id/%s",
>  			bios_info[i].dmi_field);
>  		if ((data = fwts_get(path)) != NULL) {
>  			fwts_chop_newline(data);
> diff --git a/src/bios/ebda_region/ebda_region.c b/src/bios/ebda_region/ebda_region.c
> index 3f92e0ab..a647fff2 100644
> --- a/src/bios/ebda_region/ebda_region.c
> +++ b/src/bios/ebda_region/ebda_region.c
> @@ -95,7 +95,7 @@ static int ebda_test1(fwts_framework *fw)
>  			"EBDAMappedNotReserved",
>  			"EBDA region mapped at 0x%lx but not reserved in the %s table.",
>  			ebda_addr, memory_map_name);
> -		
> +
>  	return FWTS_OK;
>  }
>  
> diff --git a/src/example/blank/blank.c b/src/example/blank/blank.c
> index 6eb1e231..6bb7b344 100644
> --- a/src/example/blank/blank.c
> +++ b/src/example/blank/blank.c
> @@ -44,7 +44,7 @@ static int example_deinit(fwts_framework *fw)
>  static int example_test1(fwts_framework *fw)
>  {
>  	/* Do your test */
> -	
> +
>  	/* Log success or failure */
>  	fwts_passed(fw, "Test passed, hurrah!");
>  	/*
> @@ -61,7 +61,7 @@ static int example_test1(fwts_framework *fw)
>  static int example_test2(fwts_framework *fw)
>  {
>  	/* Do your test */
> -	
> +
>  	/* Log success or failure */
>  	fwts_passed(fw, "Test passed, hurrah!");
>  	/*
> diff --git a/src/kernel/klog/klog.c b/src/kernel/klog/klog.c
> index c72feac3..485fa108 100644
> --- a/src/kernel/klog/klog.c
> +++ b/src/kernel/klog/klog.c
> @@ -63,7 +63,7 @@ static int klog_test1(fwts_framework *fw)
>  		return FWTS_ERROR;
>  	}
>  
> -	if (errors > 0) 
> +	if (errors > 0)
>  		/* Checks will log errors as failures automatically */
>  		fwts_log_info(fw, "Found %d unique errors in kernel log.",
>  			errors);
> diff --git a/src/lib/src/fwts_interactive.c b/src/lib/src/fwts_interactive.c
> index 2917aa0d..690b7b59 100644
> --- a/src/lib/src/fwts_interactive.c
> +++ b/src/lib/src/fwts_interactive.c
> @@ -66,7 +66,7 @@ int fwts_printf(fwts_framework *fw, const char *fmt, ...)
>  {
>  	int len;
>  	va_list ap;
> -	
> +
>  	FWTS_UNUSED(fw);
>  
>  	va_start(ap, fmt);
> diff --git a/src/lib/src/fwts_ioport.c b/src/lib/src/fwts_ioport.c
> index 398d2c12..f8b86e89 100644
> --- a/src/lib/src/fwts_ioport.c
> +++ b/src/lib/src/fwts_ioport.c
> @@ -146,7 +146,7 @@ int fwts_outl(uint32_t port, uint32_t value)
>   *  set to ~0.
>   */
>  int fwts_inb(uint32_t port, uint8_t *value)
> -{	
> +{
>  	FWTS_UNUSED(port);
>  
>  	*value = ~0;
> diff --git a/src/lib/src/fwts_oops.c b/src/lib/src/fwts_oops.c
> index cb7d047d..d58bbe2a 100644
> --- a/src/lib/src/fwts_oops.c
> +++ b/src/lib/src/fwts_oops.c
> @@ -71,7 +71,7 @@ static void fwts_klog_stack_dump(
>  		 * We are looking for an Oops message within 5 lines of a "BUG:"
>  		 * or we've got a WARN_ON then, OK, otherwise abort.
>  		 */
> -		if ((lines > 5) && 
> +		if ((lines > 5) &&
>  		    (!(dumpable & (FWTS_OOPS_GOT_OOPS | FWTS_OOPS_GOT_WARN_ON))))
>  			return;
>  
> diff --git a/src/libfwtsacpica/fwts_acpica.c b/src/libfwtsacpica/fwts_acpica.c
> index 65dad3c5..89f72aaf 100644
> --- a/src/libfwtsacpica/fwts_acpica.c
> +++ b/src/libfwtsacpica/fwts_acpica.c
> @@ -60,7 +60,7 @@
>  #define ACPI_ADR_SPACE_USER_DEFINED1	(0x80)
>  #define ACPI_ADR_SPACE_USER_DEFINED2	(0xE4)
>  
> -/* 
> +/*
>   *  Semaphore accounting info
>   */
>  typedef struct {
> diff --git a/src/uefi/securebootcert/securebootcert.c b/src/uefi/securebootcert/securebootcert.c
> index fdf5e482..7cc8dd27 100644
> --- a/src/uefi/securebootcert/securebootcert.c
> +++ b/src/uefi/securebootcert/securebootcert.c
> @@ -487,7 +487,7 @@ static int securebootcert_test1(fwts_framework *fw)
>  				"Secureboot or deployed mode on, but the variable KEK not found.");
>  	} else {
>  		if (!(var_found & VAR_DB_FOUND))
> -			fwts_log_info(fw, "Not in readiness for secureboot, variable DB not found.");		
> +			fwts_log_info(fw, "Not in readiness for secureboot, variable DB not found.");
>  		if (!(var_found & VAR_KEK_FOUND))
>  			fwts_log_info(fw, "Not in readiness for secureboot, variable KEK not found.");
>  	}
> 

Acked-by: Alex Hung <alex.hung at canonical.com>



More information about the fwts-devel mailing list