ACK: [PATCH] acpi: method: define marcos for D3hot and D3cold

Colin Ian King colin.king at canonical.com
Thu Nov 26 10:00:20 UTC 2020


On 26/11/2020 01:44, Alex Hung wrote:
> Signed-off-by: Alex Hung <alex.hung at canonical.com>
> ---
>  src/acpi/method/method.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c
> index b857913c..9454b4a6 100644
> --- a/src/acpi/method/method.c
> +++ b/src/acpi/method/method.c
> @@ -262,6 +262,9 @@
>   * _WED 	 N
>   */
>  
> +#define DEVICE_D3HOT	3
> +#define DEVICE_D3COLD	4
> +
>  static bool fadt_mobile_platform;	/* True if a mobile platform */
>  
>  #define method_test_integer(name, type)				\
> @@ -1570,7 +1573,7 @@ static int method_test_PSW(fwts_framework *fw)
>  #define method_test_SxD(name)						\
>  static int method_test ## name(fwts_framework *fw)			\
>  {									\
> -	uint64_t max = 3;						\
> +	uint64_t max = DEVICE_D3HOT;					\
>  	return method_evaluate_method(fw, METHOD_OPTIONAL,		\
>  		# name, NULL, 0, fwts_method_test_integer_max_return, &max);	\
>  }
> @@ -1583,7 +1586,7 @@ method_test_SxD(_S4D)
>  #define method_test_SxW(name)						\
>  static int method_test ## name(fwts_framework *fw)			\
>  {									\
> -	uint64_t max = 4;						\
> +	uint64_t max = DEVICE_D3COLD;					\
>  	return method_evaluate_method(fw, METHOD_OPTIONAL,		\
>  		# name, NULL, 0, fwts_method_test_integer_max_return, &max);	\
>  }
> 

Thanks Alex.

Acked-by: Colin Ian King <colin.king at canonical.com>



More information about the fwts-devel mailing list