ACK: [PATCH] lib: fwts_json: fix memory leaks on error return paths
Alex Hung
alex.hung at canonical.com
Mon Nov 16 17:55:33 UTC 2020
On 2020-11-16 2:54 a.m., Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
>
> Memory leaks of str and tmp are occurring on error return paths, free
> them before returning.
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
> src/lib/src/fwts_json.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/src/lib/src/fwts_json.c b/src/lib/src/fwts_json.c
> index 130e5ccb..c92dd512 100644
> --- a/src/lib/src/fwts_json.c
> +++ b/src/lib/src/fwts_json.c
> @@ -924,9 +924,12 @@ static char *json_object_to_json_string_indent(json_object *obj, int indent)
> if (!str)
> return NULL;
> tmp = str_escape((char *)obj->u.ptr);
> - if (!tmp)
> + if (!tmp) {
> + free(str);
> return NULL;
> + }
> str = str_append(str, tmp);
> + free(tmp);
> if (!str)
> return NULL;
> str = str_append(str, "\"");
>
Acked-by: Alex Hung <alex.hung at canonical.com>
More information about the fwts-devel
mailing list