ACK: [PATCH] acpi/method: fix _SxW which can return 4

ivanhu ivan.hu at canonical.com
Mon Nov 9 01:53:49 UTC 2020



On 11/5/20 8:01 AM, Alex Hung wrote:
> ACPI spec allows _SxW to return 4 for D3cold as the following:
> 
> "If it has indicated _PR3 support, the value "3" represents D3hot and
> the value "4" represents D3cold."
> 
> Signed-off-by: Alex Hung <alex.hung at canonical.com>
> ---
>  src/acpi/method/method.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c
> index c4939087..b857913c 100644
> --- a/src/acpi/method/method.c
> +++ b/src/acpi/method/method.c
> @@ -1583,7 +1583,7 @@ method_test_SxD(_S4D)
>  #define method_test_SxW(name)						\
>  static int method_test ## name(fwts_framework *fw)			\
>  {									\
> -	uint64_t max = 3;						\
> +	uint64_t max = 4;						\
>  	return method_evaluate_method(fw, METHOD_OPTIONAL,		\
>  		# name, NULL, 0, fwts_method_test_integer_max_return, &max);	\
>  }
> 

Acked-by: Ivan Hu <ivan.hu at canonical.com>



More information about the fwts-devel mailing list