ACK: [PATCH 01/10] dmicheck: test feature flags in type 2

Colin Ian King colin.king at canonical.com
Tue May 26 16:19:25 UTC 2020


On 21/05/2020 03:37, Alex Hung wrote:
> Signed-off-by: Alex Hung <alex.hung at canonical.com>
> ---
>  src/dmi/dmicheck/dmicheck.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c
> index c53bf163..46d7e620 100644
> --- a/src/dmi/dmicheck/dmicheck.c
> +++ b/src/dmi/dmicheck/dmicheck.c
> @@ -1260,6 +1260,7 @@ static void dmicheck_entry(fwts_framework *fw,
>  			dmi_str_check(fw, table, addr, "Asset Tag", hdr, 0x8);
>  			if (hdr->length < 0x0f)
>  				break;
> +			dmi_reserved_bits_check(fw, table, addr, "Feature Flags", hdr, sizeof(uint8_t), 0x9, 5, 7);
>  			dmi_str_check(fw, table, addr, "Location In Chassis", hdr, 0xa);
>  			dmi_min_max_uint8_check(fw, table, addr, "Type", hdr, 0xd, 0x1, 0xd);
>  			break;
> 
Acked-by: Colin Ian King <colin.king at canonical.com>



More information about the fwts-devel mailing list