[PATCH] lib: fwts_summary: fix build warning with gcc-10

Colin King colin.king at canonical.com
Thu Mar 19 00:35:39 UTC 2020


From: Colin Ian King <colin.king at canonical.com>

Provide enough buffer space to clean up gcc-10 build warnings such
as the following:

fwts_summary.c:178:29: error: '%5u' directive output may be
truncated writing between 5 and 10 bytes into a region of
size 6 [-Werror=format-truncation=]
  178 |   snprintf(buffer, buflen, "%5u", value);
      |                             ^~~
fwts_summary.c:178:28: note: directive argument in the range [1, 4294967295]
  178 |   snprintf(buffer, buflen, "%5u", value);
      |                            ^~~~~

Signed-off-by: Colin Ian King <colin.king at canonical.com>
---
 src/lib/src/fwts_summary.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/lib/src/fwts_summary.c b/src/lib/src/fwts_summary.c
index 0836665c..8529b01b 100644
--- a/src/lib/src/fwts_summary.c
+++ b/src/lib/src/fwts_summary.c
@@ -246,12 +246,12 @@ int fwts_summary_report(fwts_framework *fw, fwts_list *test_list)
 		fwts_list_foreach(item, sorted) {
 			fwts_framework_test *test = fwts_list_data(fwts_framework_test*,item);
 			if (test->was_run) {
-				char passed[6];
-				char failed[6];
-				char aborted[6];
-				char warning[6];
-				char skipped[6];
-				char infoonly[6];
+				char passed[16];
+				char failed[16];
+				char aborted[16];
+				char warning[16];
+				char skipped[16];
+				char infoonly[16];
 
 				fwts_summary_format_field(passed, sizeof(passed), test->results.passed);
 				fwts_summary_format_field(failed, sizeof(failed), test->results.failed);
-- 
2.25.1




More information about the fwts-devel mailing list