[PATCH] lib: fwts_memorymap: fix resource leak on dir on error return path

Colin King colin.king at canonical.com
Mon Jan 13 11:48:12 UTC 2020


From: Colin Ian King <colin.king at canonical.com>

The error return path is leaking object dir, call closedir to fix
this leak.

Signed-off-by: Colin Ian King <colin.king at canonical.com>
---
 src/lib/src/fwts_memorymap.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/lib/src/fwts_memorymap.c b/src/lib/src/fwts_memorymap.c
index 241b552e..038ccd63 100644
--- a/src/lib/src/fwts_memorymap.c
+++ b/src/lib/src/fwts_memorymap.c
@@ -315,6 +315,7 @@ fwts_list *fwts_memory_map_table_load(fwts_framework *fw)
 			entry = fwts_memory_map_table_read_entry(directory->d_name);
 			if (!entry) {
 				fwts_memory_map_table_free(memory_map_list);
+				(void)closedir(dir);
 				return NULL;
 			}
 			fwts_list_add_ordered(memory_map_list, entry, fwts_fwts_memory_map_entry_compare);
-- 
2.24.0




More information about the fwts-devel mailing list