[PATCH 2/2] fwts-test: sync up with fwts_acpi_reserved_zero_check

Alex Hung alex.hung at canonical.com
Sat Dec 19 03:49:18 UTC 2020


Signed-off-by: Alex Hung <alex.hung at canonical.com>
---
 fwts-test/dbg2-0001/dbg2-0002.log | 4 +++-
 fwts-test/dbgp-0001/dbgp-0001.log | 4 +---
 fwts-test/dbgp-0001/dbgp-0002.log | 4 +---
 fwts-test/facs-0001/facs-0001.log | 2 +-
 fwts-test/facs-0001/facs-0002.log | 6 +++---
 5 files changed, 9 insertions(+), 11 deletions(-)

diff --git a/fwts-test/dbg2-0001/dbg2-0002.log b/fwts-test/dbg2-0001/dbg2-0002.log
index 1907dc83..ba9ac24b 100644
--- a/fwts-test/dbg2-0001/dbg2-0002.log
+++ b/fwts-test/dbg2-0001/dbg2-0002.log
@@ -23,6 +23,8 @@ dbg2            FAILED [HIGH] DBG2NonZeroRevision: Test 1, DBG2 Info
 dbg2            Structure Revision is 0x01 and was expecting 0x00
 dbg2            FAILED [HIGH] DBG2PortSubTypeReserved: Test 1, DBG2 Info
 dbg2            Structure Port Subtype is 0x0008 which is a reserved type.
+dbg2            FAILED [MEDIUM] DBG2ReservedNonZero: Test 1, DBG2 Info
+dbg2            Structure Reserved field must be zero, got 0x00f0 instead
 dbg2              Namespace String:         '\_SB.PCI0.EHC1.HUB0.PRT2'
 dbg2            FAILED [HIGH] DBG2DeviceNotFound: Test 1, DBG2 Device
 dbg2            '\_SB.PCI0.EHC1.HUB0.PRT2' not found in ACPI object name
@@ -46,6 +48,6 @@ dbg2
 dbg2            Test 2 of 2: DBG2 ARM SBSA Generic UART test,
 dbg2            
 dbg2            ==========================================================
-dbg2            0 passed, 8 failed, 0 warning, 0 aborted, 0 skipped, 0
+dbg2            0 passed, 9 failed, 0 warning, 0 aborted, 0 skipped, 0
 dbg2            info only.
 dbg2            ==========================================================
diff --git a/fwts-test/dbgp-0001/dbgp-0001.log b/fwts-test/dbgp-0001/dbgp-0001.log
index 9f28a553..ad03ee16 100644
--- a/fwts-test/dbgp-0001/dbgp-0001.log
+++ b/fwts-test/dbgp-0001/dbgp-0001.log
@@ -3,9 +3,7 @@ dbgp            ----------------------------------------------------------
 dbgp            Test 1 of 1: DBGP (Debug Port) Table test.
 dbgp            DBGP Table:
 dbgp              Interface Type            0x00 (Full 16550 interface)
-dbgp              Reserved:                 0x00
-dbgp              Reserved:                 0x00
-dbgp              Reserved:                 0x00
+dbgp              Reserved:                 0x00000000
 dbgp              Base Address:
 dbgp                Address Space ID:       0x01
 dbgp                Register Bit Width      0x08
diff --git a/fwts-test/dbgp-0001/dbgp-0002.log b/fwts-test/dbgp-0001/dbgp-0002.log
index bf5d7808..f05d02a5 100644
--- a/fwts-test/dbgp-0001/dbgp-0002.log
+++ b/fwts-test/dbgp-0001/dbgp-0002.log
@@ -3,9 +3,7 @@ dbgp            ----------------------------------------------------------
 dbgp            Test 1 of 1: DBGP (Debug Port) Table test.
 dbgp            DBGP Table:
 dbgp              Interface Type            0x04 (Reserved)
-dbgp              Reserved:                 0x00
-dbgp              Reserved:                 0x00
-dbgp              Reserved:                 0x00
+dbgp              Reserved:                 0x00000000
 dbgp              Base Address:
 dbgp                Address Space ID:       0x05
 dbgp                Register Bit Width      0x00
diff --git a/fwts-test/facs-0001/facs-0001.log b/fwts-test/facs-0001/facs-0001.log
index 7c804238..8394bf80 100644
--- a/fwts-test/facs-0001/facs-0001.log
+++ b/fwts-test/facs-0001/facs-0001.log
@@ -11,7 +11,7 @@ facs              Global Lock:              0x00000000
 facs              Flags:                    0x00000000
 facs              X-Firmware Waking Vector: 0x0000000000000000
 facs              Version:                  0x01
-facs              Reserved:                 0x00 0x00 0x00
+facs              Reserved:                 0x00000000
 facs              OSPM Flags:               0x00000000
 facs              Reserved:                 0x00 0x00 0x00 0x00
 facs              Reserved:                 0x00 0x00 0x00 0x00
diff --git a/fwts-test/facs-0001/facs-0002.log b/fwts-test/facs-0001/facs-0002.log
index 68b2ee4c..dc61e3c8 100644
--- a/fwts-test/facs-0001/facs-0002.log
+++ b/fwts-test/facs-0001/facs-0002.log
@@ -11,7 +11,7 @@ facs              Global Lock:              0x00000000
 facs              Flags:                    0xffffffff
 facs              X-Firmware Waking Vector: 0x0000000000000000
 facs              Version:                  0x01
-facs              Reserved:                 0xaa 0x55 0xaa
+facs              Reserved:                 0x00aa55aa
 facs              OSPM Flags:               0xefefefef
 facs              Reserved:                 0x00 0x00 0x00 0x00
 facs              Reserved:                 0x00 0x00 0x00 0x00
@@ -19,8 +19,8 @@ facs              Reserved:                 0x00 0x00 0x01 0x00
 facs              Reserved:                 0x00 0x00 0x00 0x00
 facs              Reserved:                 0x00 0x00 0x00 0x00
 facs              Reserved:                 0x00 0x00 0x00 0x00
-facs            FAILED [LOW] FACSInvalidReserved1: Test 1, FACS: 1st
-facs            Reserved field is non-zero
+facs            FAILED [MEDIUM] FACSReservedNonZero: Test 1, FACS Reserved
+facs            field must be zero, got 0x00aa55aa instead
 facs            FAILED [HIGH] FACSReservedBitsNonZero: Test 1, FACS Flags
 facs            Bits [31..2] must be zero, got 0xffffffff instead
 facs            FAILED [HIGH] FACSReservedBitsNonZero: Test 1, FACS OSPM
-- 
2.25.1




More information about the fwts-devel mailing list