[PATCH] lib: fwts_json: fix memory leak on error return path

Colin King colin.king at canonical.com
Mon Aug 24 09:25:00 UTC 2020


From: Colin Ian King <colin.king at canonical.com>

A memory leak of str is occurring on an error return path, free
str before returning.

Signed-off-by: Colin Ian King <colin.king at canonical.com>
---
 src/lib/src/fwts_json.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/lib/src/fwts_json.c b/src/lib/src/fwts_json.c
index b92a241a..8f2c396d 100644
--- a/src/lib/src/fwts_json.c
+++ b/src/lib/src/fwts_json.c
@@ -832,8 +832,10 @@ static char *json_object_to_json_string_indent(json_object *obj, int indent)
 			for (i = 0; i < obj->length; i++) {
 				char *obj_str = json_object_to_json_string_indent(obj_ptr[i], indent + 1);
 
-				if (!obj_str)
+				if (!obj_str) {
+					free(str);
 					return NULL;
+				}
 				str = str_append(str, obj_str);
 				if (!str)
 					return NULL;
-- 
2.27.0




More information about the fwts-devel mailing list