ACK: [PATCH] dmicheck: update Memory Device type 17 size/version check (LP: #1892479)
ivanhu
ivan.hu at canonical.com
Mon Aug 24 02:16:02 UTC 2020
On 8/21/20 5:50 PM, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
>
> BugLink: https://bugs.launchpad.net/fwts/+bug/1892479
>
> Update size check according to SMBIOS specfication [1], page 99, Table 75
> that states:
>
> "Length of the structure, 15hfor version 2.1, 1Bh for version 2.3,
> 1Ch for version 2.6, 22h for version 2.7, 28h for version 2.8,
> 54h for version 3.2, 5Ch for version 3.3 and later"
>
> Ref: [1] https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_3.4.0.pdf
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
> src/dmi/dmicheck/dmicheck.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c
> index 023bf485..259279fb 100644
> --- a/src/dmi/dmicheck/dmicheck.c
> +++ b/src/dmi/dmicheck/dmicheck.c
> @@ -289,6 +289,8 @@ static const fwts_dmi_type_length type_info[] = {
> { 17, 0x207, 0x206, 0x1c },
> { 17, 0x208, 0x207, 0x22 },
> { 17, 0x302, 0x208, 0x28 },
> + { 17, 0x303, 0x302, 0x54 },
> + { 17, MAX_VERSION, 0x303, 0x5c },
> { 19, 0x207, 0x201, 0xf },
> { 19, MAX_VERSION, 0x207, 0x1f },
> { 20, 0x207, 0x201, 0x13 },
>
Acked-by: Ivan Hu <ivan.hu at canonical.com>
More information about the fwts-devel
mailing list