ACPI: Check for missing D3 support in power state controlling object

[Alex Hung]

On Fri, Apr 24, 2020 at 2:12 AM Paul Menzel <pmenzel at molgen.mpg.de> wrote:

> Dear Alex,
>
>
> Am 23.04.20 um 22:45 schrieb Alex Hung:
> > Currently FWTS checks the the following (see method_test_PS0 in method.c)
> >
> > If (_PS0 exist)
> >     Either one of _PS1, _PS2 or _PS3 must exist
> >
> > This will not generate errors in the original coreboot since it has _PS1
> >
> > The coreboot code changes focused on _PS1 to _PS3. Do you suggest
> checking
> > the following?
> >
> > If (_PS0 exist)
> >     Check _PS3 exist
> >
> > I think this is doable, but I would add some phrases like "Some OS
> requires
> > _PS3 when _PS0 exists" to indicate this may be OS-specific instead of
> > spec-specific since I wasn't able to find the requirement in ACPI spec.
>
> Patrick G. found chapter 7.3, page 486:
>
> > If any ACPI Object that controls power (_PSx or _PRx, where x = 0, 1,
> > 2, or 3) exists, then methods to set the device into D0 and D3 device
> > states (at least) must be present.
>
Great. Thanks



>
> > I will also make it HIGH failure too. If this is agreed, I can send out a
> > patch for reviews.
>
> That’d be great.
>
>
> Kind regards,
>
> Paul
>


-- 
Cheers,
Alex Hung
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/fwts-devel/attachments/20200424/479103db/attachment.html>