ACPI: Check for missing D3 support in power state controlling object

[Alex Hung]

Hi Paul,

Currently FWTS checks the the following (see method_test_PS0 in method.c)

If (_PS0 exist)
   Either one of _PS1, _PS2 or _PS3 must exist

This will not generate errors in the original coreboot since it has _PS1

The coreboot code changes focused on _PS1 to _PS3. Do you suggest checking
the following?

If (_PS0 exist)
   Check _PS3 exist

I think this is doable, but I would add some phrases like "Some OS requires
_PS3 when _PS0 exists" to indicate this may be OS-specific instead of
spec-specific since I wasn't able to find the requirement in ACPI spec. I
will also make it HIGH failure too. If this is agreed, I can send out a
patch for reviews.


On Sun, Mar 29, 2020 at 9:29 AM Paul Menzel <pmenzel at molgen.mpg.de> wrote:

> Dear fwts folks,
>
>
> Microsoft Windows showed the ACPI error below on a device with a
> coreboot based firmware [1].
>
> > Stop Error Code=0xA5 (as Before), Parameter1=0xD,
> Parameter2=0xFFFFFA8004815A00, Parameter3=0x000000003353505F, Parameter4=0x0
>
> Nico solved the problem [2]:
>
> > Spec says if any object to control the power state exists, at least
> > D0 and D3 must be supported. And it seems Windows complains about the
> > missing D3 support: https://ticket.coreboot.org/issues/257
> >
> > Windows reported `*** STOP: 0x000000A5` with the first parameter
> > `0x000000000000000D` (refers to a missing ACPI object) and the
> > third parameter `0x000000003353505F` which is the name of the
> > object in ASCII, little-endian (`_PS3`).
>
> It’d be awesome if you added a check for that to fwts. The log files are
> attached to the issue [1].
>
>
> Kind regards,
>
> Paul
>
>
> [1]: https://ticket.coreboot.org/issues/257
> [2]: https://review.coreboot.org/c/coreboot/+/39746
>
> --
> fwts-devel mailing list
> fwts-devel at lists.ubuntu.com
> Modify settings or unsubscribe at:
> https://lists.ubuntu.com/mailman/listinfo/fwts-devel
>


-- 
Cheers,
Alex Hung
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/fwts-devel/attachments/20200423/80a3abf6/attachment.html>