ACK: [PATCH 3/4] dmicheck: add Type 44 (Processor Additional Information)

[ivanhu]

On 4/7/20 8:52 AM, Alex Hung wrote:
> This was introduced in SMBIOS spec 3.3. There isn't much to check for
> the time being, though.
> 
> Signed-off-by: Alex Hung <alex.hung at canonical.com>
> ---
>  src/dmi/dmicheck/dmicheck.c | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c
> index febb0435..be206a8a 100644
> --- a/src/dmi/dmicheck/dmicheck.c
> +++ b/src/dmi/dmicheck/dmicheck.c
> @@ -1939,10 +1939,16 @@ static void dmicheck_entry(fwts_framework *fw,
>  			dmi_reserved_bits_check(fw, table, addr, "Characteristics", hdr, sizeof(uint64_t), 0x13, 6, 63);
>  			break;
>  
> -		case 126: /* 7.45 */
> +		case 44: /* 7.45 */
> +			table = "Processor Additional Information (Type 44)";
> +			if (hdr->length < 0x6)
> +				break;
> +			break;
> +
> +		case 126: /* 7.46 */
>  			table = "Inactive (Type 126)";
>  			break;
> -		case SMBIOS_END_OF_TABLE: /* 7.46 */
> +		case SMBIOS_END_OF_TABLE: /* 7.47 */
>  			table = "End of Table (Type 127)";
>  			break;
>  		default:
> 


Acked-by: Ivan Hu <ivan.hu at canonical.com>