ACK: [PATCH 1/4] dmicheck: update system slot type (type 9)

[ivanhu]

On 4/7/20 8:52 AM, Alex Hung wrote:
> New types (PCI Express Gen 4) was added in SMBIOS spec 3.3.0
> 
> Signed-off-by: Alex Hung <alex.hung at canonical.com>
> ---
>  src/dmi/dmicheck/dmicheck.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c
> index feac3693..e96b2416 100644
> --- a/src/dmi/dmicheck/dmicheck.c
> +++ b/src/dmi/dmicheck/dmicheck.c
> @@ -1427,10 +1427,10 @@ static void dmicheck_entry(fwts_framework *fw,
>  				break;
>  			dmi_str_check(fw, table, addr, "Slot Designation", hdr, 0x4);
>  			if (!(((data[0x5] >= 0x01) && (data[0x5] <= 0x23)) ||
> -			      ((data[0x5] >= 0xa0) && (data[0x5] <= 0xb6))))
> +			      ((data[0x5] >= 0xa0) && (data[0x5] <= 0xbd))))
>  				fwts_failed(fw, LOG_LEVEL_HIGH, DMI_VALUE_OUT_OF_RANGE,
>  					"Out of range value 0x%2.2" PRIx8 " "
> -					"(range allowed 0x01..0x23, 0xa0..0xb6) "
> +					"(range allowed 0x01..0x23, 0xa0..0xbd) "
>  					"while accessing entry '%s' @ 0x%8.8" PRIx32 ", "
>  					"field '%s', offset 0x%2.2x",
>  					data[0x5], table, addr, "Slot Type", 0x5);
> 


Acked-by: Ivan Hu <ivan.hu at canonical.com>