[PATCH 1/2] ebbr: add an option --ebbr for ARM's EBBR specification

[Colin Ian King]

On 20/09/2019 14:13, ivanhu wrote:
> Looks like it is not proper to direct those UEFI tests to EBBR tests
> currently.
> 
> EBBR also introduced the RuntimeServicesSupported variable to check the
> unsupported returned which is not included in current uefi tests.
> 
> I'll review the EBBR and find a way to map those tests on EBBR.
> 
> 
> Ivan

I guess this will now land in the Eoan+1 release now.

Colin

> 
> On 9/16/19 3:14 PM, Alex Hung wrote:
>> Embedded Base Boot Requirements (EBBR) is a spec from ARM that is used
>> for ARM embedded systems.
>>
>> The spec can be found @ https://github.com/ARM-software/ebbr/releases
>>
>> Signed-off-by: Alex Hung <alex.hung at canonical.com>
>> ---
>>  doc/fwts.1                       | 3 +++
>>  src/lib/include/fwts_framework.h | 3 ++-
>>  src/lib/src/fwts_framework.c     | 8 +++++++-
>>  3 files changed, 12 insertions(+), 2 deletions(-)
>>
>> diff --git a/doc/fwts.1 b/doc/fwts.1
>> index ecb34463..93431907 100644
>> --- a/doc/fwts.1
>> +++ b/doc/fwts.1
>> @@ -321,6 +321,9 @@ wakeup timer will fire during the hibernate state. The default is currently 90 s
>>  .B \-\-sbbr
>>  run ARM SBBR tests
>>  .TP
>> +.B \-\-ebbr
>> +run ARM EBBR tests
>> +.TP
>>  .B \-p, \-\-show\-progress
>>  show the progress of the tests being run. Each test will identified as it is being
>>  run. For long tests, a percentage of completion time will be displayed. As of fwts
>> diff --git a/src/lib/include/fwts_framework.h b/src/lib/include/fwts_framework.h
>> index 47eba368..74e12657 100644
>> --- a/src/lib/include/fwts_framework.h
>> +++ b/src/lib/include/fwts_framework.h
>> @@ -61,7 +61,8 @@ typedef enum {
>>  	FWTS_FLAG_SHOW_TESTS_FULL		= 0x00200000,
>>  	FWTS_FLAG_SHOW_TESTS_CATEGORIES		= 0x00400000,
>>  	FWTS_FLAG_TEST_COMPLIANCE_ACPI		= 0x00800000,
>> -	FWTS_FLAG_TEST_SBBR			= 0x01000000
>> +	FWTS_FLAG_TEST_SBBR			= 0x01000000,
>> +	FWTS_FLAG_TEST_EBBR			= 0x02000000
>>  } fwts_framework_flags;
>>  
>>  #define FWTS_FLAG_TEST_MASK		\
>> diff --git a/src/lib/src/fwts_framework.c b/src/lib/src/fwts_framework.c
>> index 698fa49a..be7b79b6 100644
>> --- a/src/lib/src/fwts_framework.c
>> +++ b/src/lib/src/fwts_framework.c
>> @@ -57,7 +57,8 @@ typedef struct {
>>  	 FWTS_FLAG_TEST_UEFI |			\
>>  	 FWTS_FLAG_TEST_ACPI |			\
>>  	 FWTS_FLAG_TEST_COMPLIANCE_ACPI |	\
>> -	 FWTS_FLAG_TEST_SBBR)
>> +	 FWTS_FLAG_TEST_SBBR |			\
>> +	 FWTS_FLAG_TEST_EBBR)
>>  
>>  static const fwts_categories categories[] = {
>>  	{ "ACPI",			FWTS_FLAG_TEST_ACPI },
>> @@ -136,6 +137,7 @@ static fwts_option fwts_framework_options[] = {
>>  	{ "sbbr",		"",   0, "Run ARM SBBR tests." },
>>  	{ "ifv",		"",   0, "Run tests in firmware-vendor modes." },
>>  	{ "clog",		"",   1, "Specify a coreboot logfile dump" },
>> +	{ "ebbr",		"",   0, "Run ARM EBBR tests." },
>>  	{ NULL, NULL, 0, NULL }
>>  };
>>  
>> @@ -1338,6 +1340,10 @@ int fwts_framework_options_handler(fwts_framework *fw, int argc, char * const ar
>>  			break;
>>  		case 48: /* --coreboot-log */
>>  			fwts_framework_strdup(&fw->clog, optarg);
>> +			break;
>> +		case 49: /* --ebbr */
>> +			fw->flags |= FWTS_FLAG_TEST_EBBR;
>> +			break;
>>  
>>  		}
>>  		break;
> 
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/fwts-devel/attachments/20190924/cf67ae9c/attachment.sig>