[PATCH] debugger: check for memory allocation failure on object Elements

Colin King colin.king at canonical.com
Wed Nov 27 13:07:54 UTC 2019


From: Colin Ian King <colin.king at canonical.com>

The allocation of Elements may fail, so add a null check to
avoid any null pointer dereference faulting.

Signed-off-by: Colin Ian King <colin.king at canonical.com>
---
 src/acpica/source/components/debugger/dbconvert.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/acpica/source/components/debugger/dbconvert.c b/src/acpica/source/components/debugger/dbconvert.c
index 6b58bf5f..a9014b8f 100644
--- a/src/acpica/source/components/debugger/dbconvert.c
+++ b/src/acpica/source/components/debugger/dbconvert.c
@@ -354,6 +354,10 @@ AcpiDbConvertToPackage (
 
     Elements = ACPI_ALLOCATE_ZEROED (
         DB_DEFAULT_PKG_ELEMENTS * sizeof (ACPI_OBJECT));
+    if (!Elements)
+    {
+        return (AE_NO_MEMORY);
+    }
 
     This = String;
     for (i = 0; i < (DB_DEFAULT_PKG_ELEMENTS - 1); i++)
-- 
2.24.0




More information about the fwts-devel mailing list