[PATCH] efi_runtime: don't build dkms module for kernels 4.8.0 and above (LP: #1853090)

[Colin Ian King]

On 21/11/2019 20:45, Alex Hung wrote:
> Hi Colin,
> 
> With the patch, I get the below result when running "sudo autopkgtest
> . -- null" on 18.04.3
> 
> autopkgtest [13:34:40]: test command1: -----------------------]
> autopkgtest [13:34:40]: test command1:  - - - - - - - - - - results -
> - - - - - - - - -
> command1             FAIL non-zero exit status 1
> autopkgtest [13:34:40]: @@@@@@@@@@@@@@@@@@@@ summary
> command1             FAIL non-zero exit status 1
> autopkgtest [13:34:40]: Binaries: resetting testbed apt configuration
> 
> 
> ========================================
> Without the patch, the result is
> 
> autopkgtest [13:42:39]: test command1: -----------------------]
> autopkgtest [13:42:39]: test command1:  - - - - - - - - - - results -
> - - - - - - - - -
> command1             PASS
> autopkgtest [13:42:39]: @@@@@@@@@@@@@@@@@@@@ summary
> command1             PASS
> autopkgtest [13:42:39]: Binaries: resetting testbed apt configuration
> 
> 
> I recall running new autopkgtest on 19.10 will get passes, but does
> this mean it will be fine?

Good question. I'll check this out tomorrow.

> 
> On Thu, Nov 21, 2019 at 12:37 PM Colin King <colin.king at canonical.com> wrote:
>>
>> From: Colin Ian King <colin.king at canonical.com>
>>
>> BugLink: https://bugs.launchpad.net/bugs/1853090
>>
>> Use the dkms OBSOLETE_BY setting to skip building the efi driver
>> for kernels >= 4.8.0
>>
>> With this setting we get dkms installs to do the following:
>>
>> Unpacking fwts-efi-runtime-dkms (19.11.00-0ubuntu1) over (19.11.00-0ubuntu1) ...
>> Setting up fwts-efi-runtime-dkms (19.11.00-0ubuntu1) ...
>> Loading new fwts-efi-runtime-dkms-19.11.00 DKMS files...
>> Building for 5.3.0-19-generic
>> Building initial module for 5.3.0-19-generic
>> This system doesn't support Secure Boot
>> Secure Boot not enabled on this system.
>> Done.
>>
>> efi_runtime.ko:
>> Running module version sanity check.
>>
>> Module has been obsoleted due to being included
>> in kernel 4.8.0.  We will avoid installing
>> for future kernels above 4.8.0.
>> You may override by specifying --force.
>>
>> depmod...
>>
>> DKMS: install completed.
>>
>> Signed-off-by: Colin Ian King <colin.king at canonical.com>
>> ---
>>  debian/fwts-efi-runtime-dkms.dkms | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/debian/fwts-efi-runtime-dkms.dkms b/debian/fwts-efi-runtime-dkms.dkms
>> index 94b3415b..33c24e46 100644
>> --- a/debian/fwts-efi-runtime-dkms.dkms
>> +++ b/debian/fwts-efi-runtime-dkms.dkms
>> @@ -4,3 +4,4 @@ MAKE[0]="KVER=$kernelver make"
>>  BUILT_MODULE_NAME[0]="efi_runtime"
>>  DEST_MODULE_LOCATION[0]="/updates"
>>  AUTOINSTALL="yes"
>> +OBSOLETE_BY="4.8.0"
>> --
>> 2.24.0
>>
>>
>> --
>> fwts-devel mailing list
>> fwts-devel at lists.ubuntu.com
>> Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/fwts-devel
> 
> 
>