ACK: [PATCH] dsddump: fix Package loop condition
Colin Ian King
colin.king at canonical.com
Fri May 31 14:41:09 UTC 2019
On 31/05/2019 14:46, Erico Nunes wrote:
> Fix the loop condition on the dsddump test.
> Without this, dsddump segfaults fwts on platforms with a _DSD.
>
> Signed-off-by: Erico Nunes <ernunes at redhat.com>
> ---
> src/acpi/dsddump/dsddump.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/acpi/dsddump/dsddump.c b/src/acpi/dsddump/dsddump.c
> index 611789b3..1e3c26c1 100644
> --- a/src/acpi/dsddump/dsddump.c
> +++ b/src/acpi/dsddump/dsddump.c
> @@ -87,7 +87,7 @@ static void parse_device_properity(fwts_framework *fw, ACPI_OBJECT *pkg)
> ACPI_OBJECT *sub_pkg = &element->Package.Elements[1];
> uint32_t j;
>
> - for (j = 0; i < sub_pkg->Package.Count; j++)
> + for (j = 0; j < sub_pkg->Package.Count; j++)
> print_package_element(fw, &sub_pkg->Package.Elements[j]);
> } else
> print_package_element(fw, &element->Package.Elements[1]);
>
Good catch. Thanks.
Acked-by: Colin Ian King <colin.king at canonical.com>
More information about the fwts-devel
mailing list