ACK: [PATCH 2/2] fwts-test/syntaxcheck: refresh syntaxcheck test output
ivanhu
ivan.hu at canonical.com
Thu May 16 05:26:21 UTC 2019
On 5/10/19 4:47 PM, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
>
> The syntaxcheck output needs refreshing again because of changes in
> the latest ACPICA.
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
> .../syntaxcheck-0001/syntaxcheck-0001.log | 132 +++++++++++++++---
> 1 file changed, 110 insertions(+), 22 deletions(-)
>
> diff --git a/fwts-test/syntaxcheck-0001/syntaxcheck-0001.log b/fwts-test/syntaxcheck-0001/syntaxcheck-0001.log
> index e8281cdc..40bbd149 100644
> --- a/fwts-test/syntaxcheck-0001/syntaxcheck-0001.log
> +++ b/fwts-test/syntaxcheck-0001/syntaxcheck-0001.log
> @@ -6,8 +6,8 @@ syntaxcheck Test 1 of 1: Disassemble and reassemble DSDT and SSDTs.
> syntaxcheck
> syntaxcheck Checking ACPI table DSDT (#0)
> syntaxcheck
> -syntaxcheck FAILED [MEDIUM] AMLAsmUnknown: Test 1, Assembler warning
> -syntaxcheck in line 242
> +syntaxcheck FAILED [MEDIUM] AMLAsmASL_MSG_LOCAL_NOT_USED: Test 1,
> +syntaxcheck Assembler warning in line 242
> syntaxcheck Line | AML source
> syntaxcheck ----------------------------------------------------------
> syntaxcheck 00239| }
> @@ -20,8 +20,8 @@ syntaxcheck 00243| {
> syntaxcheck 00244| If (_OSI ("Linux"))
> syntaxcheck 00245| {
> syntaxcheck ==========================================================
> -syntaxcheck FAILED [MEDIUM] AMLAsmUnknown: Test 1, Assembler warning
> -syntaxcheck in line 692
> +syntaxcheck FAILED [MEDIUM] AMLAsmASL_MSG_LOCAL_NOT_USED: Test 1,
> +syntaxcheck Assembler warning in line 692
> syntaxcheck Line | AML source
> syntaxcheck ----------------------------------------------------------
> syntaxcheck 00689| Name (_PSC, Zero) // _PSC: Power State Current
> @@ -53,8 +53,8 @@ syntaxcheck ADVICE: (for Error #6136, ASL_MSG_UPPER_CASE): Characters
> syntaxcheck in literal string that are not hexadecimal letters must be
> syntaxcheck upper case.
> syntaxcheck
> -syntaxcheck FAILED [LOW] AMLAsmUnknown: Test 1, Assembler remark in
> -syntaxcheck line 722
> +syntaxcheck FAILED [LOW] AMLAsmASL_MSG_ARG_NOT_USED: Test 1, Assembler
> +syntaxcheck remark in line 722
> syntaxcheck Line | AML source
> syntaxcheck ----------------------------------------------------------
> syntaxcheck 00719| {
> @@ -67,8 +67,8 @@ syntaxcheck 00723| {
> syntaxcheck 00724| Store ("MXMTCConfigData", Debug)
> syntaxcheck 00725| Return (STAC) /* \_SB_.AMW0.STAC */
> syntaxcheck ==========================================================
> -syntaxcheck FAILED [LOW] AMLAsmUnknown: Test 1, Assembler remark in
> -syntaxcheck line 732
> +syntaxcheck FAILED [LOW] AMLAsmASL_MSG_ARG_NOT_USED: Test 1, Assembler
> +syntaxcheck remark in line 732
> syntaxcheck Line | AML source
> syntaxcheck ----------------------------------------------------------
> syntaxcheck 00729| {
> @@ -81,8 +81,8 @@ syntaxcheck 00733| {
> syntaxcheck 00734| Store ("Get MXMTCControlData: STBC = ", Debug)
> syntaxcheck 00735| Store (STBC, Debug)
> syntaxcheck ==========================================================
> -syntaxcheck FAILED [LOW] AMLAsmUnknown: Test 1, Assembler remark in
> -syntaxcheck line 739
> +syntaxcheck FAILED [LOW] AMLAsmASL_MSG_ARG_NOT_USED: Test 1, Assembler
> +syntaxcheck remark in line 739
> syntaxcheck Line | AML source
> syntaxcheck ----------------------------------------------------------
> syntaxcheck 00736| Return (STBC) /* \_SB_.AMW0.STBC */
> @@ -95,8 +95,54 @@ syntaxcheck 00740| {
> syntaxcheck 00741| Store (Arg1, STBC) /* \_SB_.AMW0.STBC */
> syntaxcheck 00742| Store ("Set MXMTCControlData: STBC = ", Debug)
> syntaxcheck ==========================================================
> -syntaxcheck FAILED [MEDIUM] AMLAsmUnknown: Test 1, Assembler warning
> -syntaxcheck in line 1902
> +syntaxcheck FAILED [HIGH] AMLAsmASL_MSG_INVALID_ADDR_FLAGS: Test 1,
> +syntaxcheck Assembler error in line 1065
> +syntaxcheck Line | AML source
> +syntaxcheck ----------------------------------------------------------
> +syntaxcheck 01062| 0x00000000, // Range Minimum
> +syntaxcheck 01063| 0xDFFFFFFF, // Range Maximum
> +syntaxcheck 01064| 0x00000000, // Translation Offset
> +syntaxcheck 01065| 0x00000000, // Length
> +syntaxcheck | ^
> +syntaxcheck | Error 6043: Invalid combination of Length and Min/Max fixed flags
> +syntaxcheck 01066| ,, _Y0D, AddressRangeMemory, TypeStatic)
> +syntaxcheck 01067| DWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed, Cacheable, ReadWrite,
> +syntaxcheck 01068| 0x00000000, // Granularity
> +syntaxcheck ==========================================================
> +syntaxcheck
> +syntaxcheck ADVICE: (for Error #6043, ASL_MSG_INVALID_ADDR_FLAGS):
> +syntaxcheck This occurs if the length is zero and just one of the
> +syntaxcheck resource MIF/MAF flags are set, or the length is non-zero
> +syntaxcheck and resource MIF/MAF flags are both set. These are illegal
> +syntaxcheck combinations and need to be fixed. See section 6.4.3.5
> +syntaxcheck Address Space Resource Descriptors of the ACPI
> +syntaxcheck specification for more details.
> +syntaxcheck
> +syntaxcheck FAILED [HIGH] AMLAsmASL_MSG_INVALID_ADDR_FLAGS: Test 1,
> +syntaxcheck Assembler error in line 1079
> +syntaxcheck Line | AML source
> +syntaxcheck ----------------------------------------------------------
> +syntaxcheck 01076| 0xFED40000, // Range Minimum
> +syntaxcheck 01077| 0xFED44FFF, // Range Maximum
> +syntaxcheck 01078| 0x00000000, // Translation Offset
> +syntaxcheck 01079| 0x00000000, // Length
> +syntaxcheck | ^
> +syntaxcheck | Error 6043: Invalid combination of Length and Min/Max fixed flags
> +syntaxcheck 01080| ,, , AddressRangeMemory, TypeStatic)
> +syntaxcheck 01081| })
> +syntaxcheck 01082| Method (_CRS, 0, Serialized) // _CRS: Current Resource Settings
> +syntaxcheck ==========================================================
> +syntaxcheck
> +syntaxcheck ADVICE: (for Error #6043, ASL_MSG_INVALID_ADDR_FLAGS):
> +syntaxcheck This occurs if the length is zero and just one of the
> +syntaxcheck resource MIF/MAF flags are set, or the length is non-zero
> +syntaxcheck and resource MIF/MAF flags are both set. These are illegal
> +syntaxcheck combinations and need to be fixed. See section 6.4.3.5
> +syntaxcheck Address Space Resource Descriptors of the ACPI
> +syntaxcheck specification for more details.
> +syntaxcheck
> +syntaxcheck FAILED [MEDIUM] AMLAsmASL_MSG_LOCAL_NOT_USED: Test 1,
> +syntaxcheck Assembler warning in line 1902
> syntaxcheck Line | AML source
> syntaxcheck ----------------------------------------------------------
> syntaxcheck 01899|
> @@ -131,8 +177,50 @@ syntaxcheck thread enters the method and blocks and then a second
> syntaxcheck thread also executes the method, ending up in two attempts
> syntaxcheck to create the object and causing a failure.
> syntaxcheck
> -syntaxcheck FAILED [MEDIUM] AMLAsmUnknown: Test 1, Assembler warning
> -syntaxcheck in line 5358
> +syntaxcheck FAILED [LOW] AMLAsmASL_MSG_LONG_SLEEP: Test 1, Assembler
> +syntaxcheck remark in line 3015
> +syntaxcheck Line | AML source
> +syntaxcheck ----------------------------------------------------------
> +syntaxcheck 03012| {
> +syntaxcheck 03013| If (LNot (DRDY))
> +syntaxcheck 03014| {
> +syntaxcheck 03015| Sleep (ASLP)
> +syntaxcheck | ^
> +syntaxcheck | Remark 2159: Very long Sleep, greater than 1 second
> +syntaxcheck 03016| }
> +syntaxcheck 03017|
> +syntaxcheck 03018| Return (LNot (DRDY))
> +syntaxcheck ==========================================================
> +syntaxcheck FAILED [LOW] AMLAsmASL_MSG_LONG_SLEEP: Test 1, Assembler
> +syntaxcheck remark in line 3025
> +syntaxcheck Line | AML source
> +syntaxcheck ----------------------------------------------------------
> +syntaxcheck 03022| {
> +syntaxcheck 03023| If (LGreater (CSTS, 0x02))
> +syntaxcheck 03024| {
> +syntaxcheck 03025| Sleep (ASLP)
> +syntaxcheck | ^
> +syntaxcheck | Remark 2159: Very long Sleep, greater than 1 second
> +syntaxcheck 03026| }
> +syntaxcheck 03027|
> +syntaxcheck 03028| Return (LEqual (CSTS, 0x03))
> +syntaxcheck ==========================================================
> +syntaxcheck FAILED [LOW] AMLAsmASL_MSG_LONG_SLEEP: Test 1, Assembler
> +syntaxcheck remark in line 3088
> +syntaxcheck Line | AML source
> +syntaxcheck ----------------------------------------------------------
> +syntaxcheck 03085| {
> +syntaxcheck 03086| If (LNot (ARDY))
> +syntaxcheck 03087| {
> +syntaxcheck 03088| Sleep (ASLP)
> +syntaxcheck | ^
> +syntaxcheck | Remark 2159: Very long Sleep, greater than 1 second
> +syntaxcheck 03089| }
> +syntaxcheck 03090|
> +syntaxcheck 03091| Return (LNot (ARDY))
> +syntaxcheck ==========================================================
> +syntaxcheck FAILED [MEDIUM] AMLAsmASL_MSG_LOCAL_NOT_USED: Test 1,
> +syntaxcheck Assembler warning in line 5358
> syntaxcheck Line | AML source
> syntaxcheck ----------------------------------------------------------
> syntaxcheck 05355| If (LEqual (Arg0, 0x03))
> @@ -145,8 +233,8 @@ syntaxcheck 05359| {
> syntaxcheck 05360| Store (Zero, BTDS) /* \_SB_.PCI0.LPCB.EC0_.BTDS */
> syntaxcheck 05361| If (_OSI ("Windows 2006"))
> syntaxcheck ==========================================================
> -syntaxcheck FAILED [LOW] AMLAsmUnknown: Test 1, Assembler remark in
> -syntaxcheck line 5688
> +syntaxcheck FAILED [LOW] AMLAsmASL_MSG_ARG_NOT_USED: Test 1, Assembler
> +syntaxcheck remark in line 5688
> syntaxcheck Line | AML source
> syntaxcheck ----------------------------------------------------------
> syntaxcheck 05685| Return (Arg1)
> @@ -203,8 +291,8 @@ syntaxcheck thread enters the method and blocks and then a second
> syntaxcheck thread also executes the method, ending up in two attempts
> syntaxcheck to create the object and causing a failure.
> syntaxcheck
> -syntaxcheck FAILED [MEDIUM] AMLAsmUnknown: Test 1, Assembler warning
> -syntaxcheck in line 5854
> +syntaxcheck FAILED [MEDIUM] AMLAsmASL_MSG_LOCAL_NOT_USED: Test 1,
> +syntaxcheck Assembler warning in line 5854
> syntaxcheck Line | AML source
> syntaxcheck ----------------------------------------------------------
> syntaxcheck 05851| If (BFC1)
> @@ -339,7 +427,7 @@ syntaxcheck thread enters the method and blocks and then a second
> syntaxcheck thread also executes the method, ending up in two attempts
> syntaxcheck to create the object and causing a failure.
> syntaxcheck
> -syntaxcheck Table DSDT (0) reassembly: Found 1 errors, 5 warnings, 14
> +syntaxcheck Table DSDT (0) reassembly: Found 3 errors, 5 warnings, 17
> syntaxcheck remarks.
> syntaxcheck
> syntaxcheck
> @@ -585,8 +673,8 @@ syntaxcheck
> syntaxcheck
> syntaxcheck Checking ACPI table SSDT (#2)
> syntaxcheck
> -syntaxcheck FAILED [MEDIUM] AMLAsmUnknown: Test 1, Assembler warning
> -syntaxcheck in line 47
> +syntaxcheck FAILED [MEDIUM] AMLAsmASL_MSG_LOCAL_NOT_USED: Test 1,
> +syntaxcheck Assembler warning in line 47
> syntaxcheck Line | AML source
> syntaxcheck ----------------------------------------------------------
> syntaxcheck 00044|
> @@ -710,6 +798,6 @@ syntaxcheck remarks.
> syntaxcheck
> syntaxcheck
> syntaxcheck ==========================================================
> -syntaxcheck 2 passed, 40 failed, 0 warning, 0 aborted, 0 skipped, 0
> +syntaxcheck 2 passed, 45 failed, 0 warning, 0 aborted, 0 skipped, 0
> syntaxcheck info only.
> syntaxcheck ==========================================================
Acked-by: Ivan Hu <ivan.hu at canonical.com>
More information about the fwts-devel
mailing list