Ack: [PATCH] cpu: microcode: remove redundant check on pointer entry

[Ivan]

在 2019年12月7日 下午11:33 於 下午11:33，Colin King <colin.king at canonical.com>曾寫：
>From: Colin Ian King <colin.king at canonical.com>
>
>The check for a null entry is redundant as the while loop
>also checks for this.  Remove the redundant check. Cleans
>up cppcheck style warning:
>
>src/cpu/microcode/microcode.c:203:14: style: Condition 'entry' is
>always true [knownConditionTrueFalse]
>         if (entry &&
>
>src/cpu/microcode/microcode.c:202:32: note: Assuming that condition
>'(entry=readdir(dir))!=NULL' is not redundant
>
> while ((entry = readdir(dir)) != NULL) {
>
>src/cpu/microcode/microcode.c:203:14: note: Condition 'entry' is
>always true
>         if (entry &&
>
>Signed-off-by: Colin Ian King <colin.king at canonical.com>
>---
> src/cpu/microcode/microcode.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/src/cpu/microcode/microcode.c
>b/src/cpu/microcode/microcode.c
>index 974fdec9..65abe50a 100644
>--- a/src/cpu/microcode/microcode.c
>+++ b/src/cpu/microcode/microcode.c
>@@ -200,8 +200,7 @@ static int microcode_test1(fwts_framework *fw)
> 
> 	/* Scan and check */
> 	while ((entry = readdir(dir)) != NULL) {
>-	        if (entry &&
>-		    (strlen(entry->d_name) > 3) &&
>+	        if ((strlen(entry->d_name) > 3) &&
> 		    (strncmp(entry->d_name,"cpu", 3) == 0) &&
> 		    (isdigit(entry->d_name[3]))) {
> 			char path[PATH_MAX];
>-- 
>2.24.0
>
>
>-- 
>fwts-devel mailing list
>fwts-devel at lists.ubuntu.com
>Modify settings or unsubscribe at:
>https://lists.ubuntu.com/mailman/listinfo/fwts-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/fwts-devel/attachments/20191209/2be4720a/attachment.html>