ACK: [PATCH] efi_runtime: don't build dkms module for kernels 4.8.0 and above (LP: #1853090)

[ivanhu]

I seems we need to find another way to find another solution to avoid
kernel lockdown if any. Currently, the only way is using kernel
parameter to unlock kernel for uefi tests when kernel lockdown.

Thanks Colin for this patch.
Ack if first to stop build DKMS, and try to find any ways to avoid the
kernel lockdown if any.


Acked-by: Ivan Hu <ivan.hu at canonical.com>


On 11/26/19 11:20 AM, ivanhu wrote:
> I would like to keep this DKMS being built, if there are no high impacts.
> 
> Because the kernel 5.4 introduced the kernel lockdown,
> https://lkml.org/lkml/2019/9/10/856, which will lock down lots of IOs
> and inteerfaces accessing including uefi on efi_test.
> 
> Besides using the kernel parameters to disable kernel lockdown, this
> DKMS may be another choice which can be run by the fwts UEFI tests under
> kernel lockdown.
> 
> 
> Cheers,
> 
> Ivan
> 
> On 11/22/19 3:37 AM, Colin King wrote:
>> From: Colin Ian King <colin.king at canonical.com>
>>
>> BugLink: https://bugs.launchpad.net/bugs/1853090
>>
>> Use the dkms OBSOLETE_BY setting to skip building the efi driver
>> for kernels >= 4.8.0
>>
>> With this setting we get dkms installs to do the following:
>>
>> Unpacking fwts-efi-runtime-dkms (19.11.00-0ubuntu1) over (19.11.00-0ubuntu1) ...
>> Setting up fwts-efi-runtime-dkms (19.11.00-0ubuntu1) ...
>> Loading new fwts-efi-runtime-dkms-19.11.00 DKMS files...
>> Building for 5.3.0-19-generic
>> Building initial module for 5.3.0-19-generic
>> This system doesn't support Secure Boot
>> Secure Boot not enabled on this system.
>> Done.
>>
>> efi_runtime.ko:
>> Running module version sanity check.
>>
>> Module has been obsoleted due to being included
>> in kernel 4.8.0.  We will avoid installing
>> for future kernels above 4.8.0.
>> You may override by specifying --force.
>>
>> depmod...
>>
>> DKMS: install completed.
>>
>> Signed-off-by: Colin Ian King <colin.king at canonical.com>
>> ---
>>  debian/fwts-efi-runtime-dkms.dkms | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/debian/fwts-efi-runtime-dkms.dkms b/debian/fwts-efi-runtime-dkms.dkms
>> index 94b3415b..33c24e46 100644
>> --- a/debian/fwts-efi-runtime-dkms.dkms
>> +++ b/debian/fwts-efi-runtime-dkms.dkms
>> @@ -4,3 +4,4 @@ MAKE[0]="KVER=$kernelver make"
>>  BUILT_MODULE_NAME[0]="efi_runtime"
>>  DEST_MODULE_LOCATION[0]="/updates"
>>  AUTOINSTALL="yes"
>> +OBSOLETE_BY="4.8.0"
> 
>