[PATCH] efi_runtime: enable KBUILD_MODPOST_WARN=y to workaround build failures

[Colin Ian King]

On 31/07/2019 01:34, Alex Hung wrote:
> Hi Colin,
> 
> Is this to solve the previous ADT issue from "[V3] efi_runtime: remove
> efi_runtime dkms" (http://patchwork.ozlabs.org/patch/1136754/)?

OK, I can clearly see what's going on. I'll try and clear up the confusion.

My fix is to address a modpost issue with kernels > 5.0, I've just
dialed back the failure message to a warning messages on arches that
don't link because the arch does not support UEFI.  My fix is nothing to
do with Ivan's fix in any way.

I had to add my patch to the packaging to get it through ADT testing
with 5.2 kernels, see
https://launchpad.net/ubuntu/+source/fwts/19.07.00-0ubuntu2

The build was working for me because I didn't have Ivan's patch. I
expect if you just use my patch you will see a successful built too.

Colin

> 
> I applied both patches and run ADT test by "sudo autopkgtest
> ./fwts_${RELEASE_VERSION}-0ubuntu1.dsc -- null" ($RELEASE_VERSION =
> 19.07.01 which is a test build), it doesn't return success. Is this
> intentional?
> 
> On Mon, Jul 29, 2019 at 5:00 PM Colin King <colin.king at canonical.com> wrote:
>>
>> From: Colin Ian King <colin.king at canonical.com>
>>
>> With newer kernels > 5.0, undefined variables now throw an error
>> rather than a warning.  Force the older warning behaviour so that
>> dkms builds can pass ADT build testing.
>>
>> Signed-off-by: Colin Ian King <colin.king at canonical.com>
>> ---
>>  efi_runtime/Makefile | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/efi_runtime/Makefile b/efi_runtime/Makefile
>> index ae868675..6ba369ce 100644
>> --- a/efi_runtime/Makefile
>> +++ b/efi_runtime/Makefile
>> @@ -17,6 +17,7 @@
>>  #
>>
>>  KVER ?= `uname -r`
>> +KBUILD_MODPOST_WARN=y
>>  obj-m += efi_runtime.o
>>  all:
>>         make -C /lib/modules/$(KVER)/build M=`pwd` modules
>> --
>> 2.20.1
>>
>>
>> --
>> fwts-devel mailing list
>> fwts-devel at lists.ubuntu.com
>> Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/fwts-devel
> 
> 
>