ACK: [PATCH 3/3] fwts-test: refresh syntaxcheck test output
Alex Hung
alex.hung at canonical.com
Fri Apr 19 06:32:16 UTC 2019
On 2019-04-08 7:51 a.m., Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
>
> The syntaxcheck output needs refreshing as a couple of remarks and
> errors are now dropped with the lates ACPCIA.
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
> .../syntaxcheck-0001/syntaxcheck-0001.log | 92 +------------------
> 1 file changed, 2 insertions(+), 90 deletions(-)
>
> diff --git a/fwts-test/syntaxcheck-0001/syntaxcheck-0001.log b/fwts-test/syntaxcheck-0001/syntaxcheck-0001.log
> index b0b014a1..e8281cdc 100644
> --- a/fwts-test/syntaxcheck-0001/syntaxcheck-0001.log
> +++ b/fwts-test/syntaxcheck-0001/syntaxcheck-0001.log
> @@ -95,52 +95,6 @@ syntaxcheck 00740| {
> syntaxcheck 00741| Store (Arg1, STBC) /* \_SB_.AMW0.STBC */
> syntaxcheck 00742| Store ("Set MXMTCControlData: STBC = ", Debug)
> syntaxcheck ==========================================================
> -syntaxcheck FAILED [HIGH] AMLAsmASL_MSG_INVALID_ADDR_FLAGS: Test 1,
> -syntaxcheck Assembler error in line 1065
> -syntaxcheck Line | AML source
> -syntaxcheck ----------------------------------------------------------
> -syntaxcheck 01062| 0x00000000, // Range Minimum
> -syntaxcheck 01063| 0xDFFFFFFF, // Range Maximum
> -syntaxcheck 01064| 0x00000000, // Translation Offset
> -syntaxcheck 01065| 0x00000000, // Length
> -syntaxcheck | ^
> -syntaxcheck | Error 6043: Invalid combination of Length and Min/Max fixed flags
> -syntaxcheck 01066| ,, _Y0D, AddressRangeMemory, TypeStatic)
> -syntaxcheck 01067| DWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed, Cacheable, ReadWrite,
> -syntaxcheck 01068| 0x00000000, // Granularity
> -syntaxcheck ==========================================================
> -syntaxcheck
> -syntaxcheck ADVICE: (for Error #6043, ASL_MSG_INVALID_ADDR_FLAGS):
> -syntaxcheck This occurs if the length is zero and just one of the
> -syntaxcheck resource MIF/MAF flags are set, or the length is non-zero
> -syntaxcheck and resource MIF/MAF flags are both set. These are illegal
> -syntaxcheck combinations and need to be fixed. See section 6.4.3.5
> -syntaxcheck Address Space Resource Descriptors of the ACPI
> -syntaxcheck specification for more details.
> -syntaxcheck
> -syntaxcheck FAILED [HIGH] AMLAsmASL_MSG_INVALID_ADDR_FLAGS: Test 1,
> -syntaxcheck Assembler error in line 1079
> -syntaxcheck Line | AML source
> -syntaxcheck ----------------------------------------------------------
> -syntaxcheck 01076| 0xFED40000, // Range Minimum
> -syntaxcheck 01077| 0xFED44FFF, // Range Maximum
> -syntaxcheck 01078| 0x00000000, // Translation Offset
> -syntaxcheck 01079| 0x00000000, // Length
> -syntaxcheck | ^
> -syntaxcheck | Error 6043: Invalid combination of Length and Min/Max fixed flags
> -syntaxcheck 01080| ,, , AddressRangeMemory, TypeStatic)
> -syntaxcheck 01081| })
> -syntaxcheck 01082| Method (_CRS, 0, Serialized) // _CRS: Current Resource Settings
> -syntaxcheck ==========================================================
> -syntaxcheck
> -syntaxcheck ADVICE: (for Error #6043, ASL_MSG_INVALID_ADDR_FLAGS):
> -syntaxcheck This occurs if the length is zero and just one of the
> -syntaxcheck resource MIF/MAF flags are set, or the length is non-zero
> -syntaxcheck and resource MIF/MAF flags are both set. These are illegal
> -syntaxcheck combinations and need to be fixed. See section 6.4.3.5
> -syntaxcheck Address Space Resource Descriptors of the ACPI
> -syntaxcheck specification for more details.
> -syntaxcheck
> syntaxcheck FAILED [MEDIUM] AMLAsmUnknown: Test 1, Assembler warning
> syntaxcheck in line 1902
> syntaxcheck Line | AML source
> @@ -177,48 +131,6 @@ syntaxcheck thread enters the method and blocks and then a second
> syntaxcheck thread also executes the method, ending up in two attempts
> syntaxcheck to create the object and causing a failure.
> syntaxcheck
> -syntaxcheck FAILED [LOW] AMLAsmUnknown: Test 1, Assembler remark in
> -syntaxcheck line 3015
> -syntaxcheck Line | AML source
> -syntaxcheck ----------------------------------------------------------
> -syntaxcheck 03012| {
> -syntaxcheck 03013| If (LNot (DRDY))
> -syntaxcheck 03014| {
> -syntaxcheck 03015| Sleep (ASLP)
> -syntaxcheck | ^
> -syntaxcheck | Remark 2159: Very long Sleep, greater than 1 second
> -syntaxcheck 03016| }
> -syntaxcheck 03017|
> -syntaxcheck 03018| Return (LNot (DRDY))
> -syntaxcheck ==========================================================
> -syntaxcheck FAILED [LOW] AMLAsmUnknown: Test 1, Assembler remark in
> -syntaxcheck line 3025
> -syntaxcheck Line | AML source
> -syntaxcheck ----------------------------------------------------------
> -syntaxcheck 03022| {
> -syntaxcheck 03023| If (LGreater (CSTS, 0x02))
> -syntaxcheck 03024| {
> -syntaxcheck 03025| Sleep (ASLP)
> -syntaxcheck | ^
> -syntaxcheck | Remark 2159: Very long Sleep, greater than 1 second
> -syntaxcheck 03026| }
> -syntaxcheck 03027|
> -syntaxcheck 03028| Return (LEqual (CSTS, 0x03))
> -syntaxcheck ==========================================================
> -syntaxcheck FAILED [LOW] AMLAsmUnknown: Test 1, Assembler remark in
> -syntaxcheck line 3088
> -syntaxcheck Line | AML source
> -syntaxcheck ----------------------------------------------------------
> -syntaxcheck 03085| {
> -syntaxcheck 03086| If (LNot (ARDY))
> -syntaxcheck 03087| {
> -syntaxcheck 03088| Sleep (ASLP)
> -syntaxcheck | ^
> -syntaxcheck | Remark 2159: Very long Sleep, greater than 1 second
> -syntaxcheck 03089| }
> -syntaxcheck 03090|
> -syntaxcheck 03091| Return (LNot (ARDY))
> -syntaxcheck ==========================================================
> syntaxcheck FAILED [MEDIUM] AMLAsmUnknown: Test 1, Assembler warning
> syntaxcheck in line 5358
> syntaxcheck Line | AML source
> @@ -427,7 +339,7 @@ syntaxcheck thread enters the method and blocks and then a second
> syntaxcheck thread also executes the method, ending up in two attempts
> syntaxcheck to create the object and causing a failure.
> syntaxcheck
> -syntaxcheck Table DSDT (0) reassembly: Found 3 errors, 5 warnings, 17
> +syntaxcheck Table DSDT (0) reassembly: Found 1 errors, 5 warnings, 14
> syntaxcheck remarks.
> syntaxcheck
> syntaxcheck
> @@ -798,6 +710,6 @@ syntaxcheck remarks.
> syntaxcheck
> syntaxcheck
> syntaxcheck ==========================================================
> -syntaxcheck 2 passed, 45 failed, 0 warning, 0 aborted, 0 skipped, 0
> +syntaxcheck 2 passed, 40 failed, 0 warning, 0 aborted, 0 skipped, 0
> syntaxcheck info only.
> syntaxcheck ==========================================================
>
Acked-by: Alex Hung <alex.hung at canonical.com>
More information about the fwts-devel
mailing list