[PATCH] lib: add PL011 to _CID whitelist

[Alex Hung]

On Wed, Nov 7, 2018 at 4:52 PM ivanhu <ivan.hu at canonical.com> wrote:
>
> I was in UEFI plugfest two, at first I think we can whitelist this ID, but
>
> ACPI specification do define the type of the IDs,
>
> A valid PNP ID must be of the form "AAA####" where A is an uppercase
> letter and # is a hex
> digit. A valid ACPI ID must be of the form "NNNN####" where N is an
> uppercase letter or a
> digit ('0'-'9') and # is a hex digit.
>
> "PL011" indeed not follow the ACPI specification.
>
> They know it is not following the ACPI specification, they cannot change
> it because the legacy machine use it.
>
> I think it maybe good idea let FWTS to spot all failures which not
> following the ACPI specification, even if it is in used.
>
> Any thoughts?

It is unlikely to undo the used CID. The failures will always be
there, even if the CID is supported by firmware and OS. This failure
will make little sense as it may never get fixed.

>
>
> Cheers,
>
> Ivan
>
> On 11/7/18 12:13 PM, Alex Hung wrote:
> > When attending UEFI Plugfest, a vendor suggested _CID PL011 is used in
> > the field, and this ID is added to a whitelist to avoid false positive.
> >
> > Signed-off-by: Alex Hung <alex.hung at canonical.com>
> > ---
> >  src/lib/src/fwts_acpi_object_eval.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/src/lib/src/fwts_acpi_object_eval.c b/src/lib/src/fwts_acpi_object_eval.c
> > index 0bc0f134..95f7df76 100644
> > --- a/src/lib/src/fwts_acpi_object_eval.c
> > +++ b/src/lib/src/fwts_acpi_object_eval.c
> > @@ -968,6 +968,10 @@ bool fwts_method_valid_HID_string(char *str)
> >               return true;
> >       }
> >
> > +     /* PL011 is used out there, so whitelist it */
> > +     if (strlen(str) == 5 && !strncmp(str, "PL011", 5))
> > +             return true;
> > +
> >       return false;
> >  }
> >
>
> --
> fwts-devel mailing list
> fwts-devel at lists.ubuntu.com
> Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/fwts-devel



-- 
Cheers,
Alex Hung