ACK: [PATCH 20/20] clog.json: add coreboot messages to clog database

[Alex Hung]

On 2018-06-20 05:14 AM, Marcello Sylvester Bauer wrote:
> Signed-off-by: Marcello Sylvester Bauer <info at marcellobauer.com>
> ---
>   data/Makefile.am |  2 +-
>   data/clog.json   | 75 +++++++++++++++++++++++++++++++++++++++++++++++++++-----
>   2 files changed, 70 insertions(+), 7 deletions(-)
> 
> diff --git a/data/Makefile.am b/data/Makefile.am
> index 3701ee9a..9636892a 100644
> --- a/data/Makefile.am
> +++ b/data/Makefile.am
> @@ -17,4 +17,4 @@
>   #
>   
>   fwtsdatadir = $(pkgdatadir)
> -fwtsdata_DATA = klog.json syntaxcheck.json olog.json
> +fwtsdata_DATA = clog.json klog.json syntaxcheck.json olog.json
> diff --git a/data/clog.json b/data/clog.json
> index f2594bcc..28452d92 100644
> --- a/data/clog.json
> +++ b/data/clog.json
> @@ -2,11 +2,74 @@
>    "firmware_error_warning_patterns":
>    [
>     {
> -    "compare_mode": "string",
> -    "log_level": "LOG_LEVEL_LOW",
> -    "pattern": "magic pattern string which will definitely not appear in the logs",
> -    "advice": "This is only a template.",
> -    "label": "template"
> -  }
> +    "compare_mode": "regex",
> +    "log_level": "LOG_LEVEL_HIGH",
> +    "pattern": "MRC:.*(invalid|failed to|Could not|failure).*",
> +    "advice": "Debug MRC cache code and check flash write protection.",
> +    "label": "MRC"
> +  },
> +  {
> +    "compare_mode": "regex",
> +    "log_level": "LOG_LEVEL_HIGH",
> +    "pattern": "GMA:.*(Error|Broken|couldn't).*",
> +    "advice": "Debug Intel GMA driver code and check VGA Option ROM and VBT included into CBFS.",
> +    "label": "GMA"
> +  },
> +  {
> +    "compare_mode": "regex",
> +    "log_level": "LOG_LEVEL_CRITICAL",
> +    "pattern": "ERROR: Not enough MTRRs available!.*",
> +    "advice": "Increase memory alignment to reduce MTRR usage.",
> +    "label": "MTRR"
> +  },
> +  {
> +    "compare_mode": "regex",
> +    "log_level": "LOG_LEVEL_HIGH",
> +    "pattern": ".*: Missing ACPI scope",
> +    "advice": "Add an ACPI name for coreboot's SSDT generator.",
> +    "label": "SSDT"
> +  },
> +  {
> +    "compare_mode": "regex",
> +    "log_level": "LOG_LEVEL_MEDIUM",
> +    "pattern": "ERROR: No timestamp.*",
> +    "advice": "Debug the timestamp code.",
> +    "label": "TIMESTAMP"
> +  },
> +  {
> +    "compare_mode": "regex",
> +    "log_level": "LOG_LEVEL_HIGH",
> +    "pattern": "Error:.*cbmem",
> +    "advice": "Debug the CBMEM code.",
> +    "label": "CBMEM"
> +  },
> +  {
> +    "compare_mode": "regex",
> +    "log_level": "LOG_LEVEL_HIGH",
> +    "pattern": "(No|Invalid) DSDT.*",
> +    "advice": "Provide or fix the DSDT file.",
> +    "label": "DSDT"
> +  },
> +  {
> +    "compare_mode": "regex",
> +    "log_level": "LOG_LEVEL_HIGH",
> +    "pattern": "ACPI: Error: Could not add ACPI table.*",
> +    "advice": "Increase MAX_ACPI_TABLES.",
> +    "label": "RSDP"
> +  },
> +  {
> +    "compare_mode": "regex",
> +    "log_level": "LOG_LEVEL_MEDIUM",
> +    "pattern": "PCI: Check your devicetree.cb.",
> +    "advice": "Check the mainboard's devicetree.cb for PCI related errors.",
> +    "label": "STATIC_PCI"
> +  },
> +  {
> +    "compare_mode": "regex",
> +    "log_level": "LOG_LEVEL_HIGH",
> +    "pattern": "PCI: Check your devicetree.cb.",
> +    "advice": "Check the mainboard's devicetree.cb for PCI related errors.",
> +    "label": "STATIC_PCI"
> +  },
>    ]
>   }
> 


Acked-by: Alex Hung <alex.hung at canonical.com>