ACK: [PATCH] acpica: fix linking issues when building non ACPI builds

Alex Hung alex.hung at canonical.com
Tue Jun 19 00:57:10 UTC 2018


On 2018-06-18 10:26 AM, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
> 
> It appears that building with older versions of gcc with ACPI disabled
> causes a linking problem as the symbol AcpiGbl_VerboseHandlers is
> not available.  The current workaround defines it as a unsigned char
> type (same as ACPI's BOOLEAN) even though we never actually use it.
> 
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>   src/acpica/fwts_acpica.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/src/acpica/fwts_acpica.c b/src/acpica/fwts_acpica.c
> index f4c45c6f..d985e18a 100644
> --- a/src/acpica/fwts_acpica.c
> +++ b/src/acpica/fwts_acpica.c
> @@ -1369,5 +1369,6 @@ VOID_FUNC(MpSaveSerialInfo)
>    * when building with ACPI disabled and I have no idea why.
>    */
>   unsigned char AcpiGbl_AbortLoopOnTimeout = FALSE;
> +unsigned char AcpiGbl_VerboseHandlers = FALSE;
>   
>   #endif
> 


Acked-by: Alex Hung <alex.hung at canonical.com>



More information about the fwts-devel mailing list