[PATCH] mtrr: fix incorrect type detection

Stan.Hung at Dell.com Stan.Hung at Dell.com
Wed Jun 13 09:08:54 UTC 2018


"Signed-off-by: Stan Hung <Stan_Hung at Dell.com<mailto:Stan_Hung at Dell.com>>"

From: Alex Hung [mailto:alex.hung at canonical.com]
Sent: Wednesday, June 13, 2018 2:27 PM
To: Hung, Stan
Cc: fwts-devel
Subject: Re: [PATCH] mtrr: fix incorrect type detection

Hi Stan,

Thanks for sending the patch; however, we also require the patch to be signed-off and send the patch by git (My apology - I should have commented on Launchpad).

I can re-send the patch for you, but I need your permission to add the "signed-off" into the patch. If you agree, please just reply with

"Signed-off-by: Stan Hung <Stan_Hung at Dell.com<mailto:Stan_Hung at Dell.com>>"

Just for the information: once the patch is sent with signed-off, it will either received comments for revising or two acks for acceptance.

On Tue, Jun 12, 2018 at 11:13 PM <Stan.Hung at dell.com<mailto:Stan.Hung at dell.com>> wrote:
Hi folks,

Here is the patch for bug: https://bugs.launchpad.net/fwts/+bug/1776427

cache_types() in mtrr.c trying to parse the memory range covered by MTRR or not.
If match, the "end" of the range will move to the the start of MTRR.

mtrr.c #234
  end = entry->start;

Ex:
  Memory 0x0000 ~ 0xFFFF
  MTRR   0x1000 ~ 0xFFFF WB
  MTRR   0x0000 ~ 0x0FFF WB

  In original flow, if we put this memory range into cache_types function.
  The first round check will update the range to 0x0000 ~ 0x1000
  Then it won't hit the 0x0000 ~ 0x0FFF MTRR and set the DEFAULT flag to identify the usage of default MTRR.

Regards,
Stan Hung
--
fwts-devel mailing list
fwts-devel at lists.ubuntu.com<mailto:fwts-devel at lists.ubuntu.com>
Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/fwts-devel


--
Cheers,
Alex Hung
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/fwts-devel/attachments/20180613/8941e462/attachment-0001.html>


More information about the fwts-devel mailing list