ACK: [PATCH] mtrr: fix incorrect type detection

Colin Ian King colin.king at canonical.com
Wed Jun 13 06:15:02 UTC 2018


On 13/06/18 06:51, Stan.Hung at Dell.com wrote:
> Hi folks,
> 
> Here is the patch for bug: https://bugs.launchpad.net/fwts/+bug/1776427
> 
> cache_types() in mtrr.c trying to parse the memory range covered by MTRR or not.
> If match, the "end" of the range will move to the the start of MTRR.
> 
> mtrr.c #234
>   end = entry->start;
> 
> Ex:
>   Memory 0x0000 ~ 0xFFFF
>   MTRR   0x1000 ~ 0xFFFF WB
>   MTRR   0x0000 ~ 0x0FFF WB
> 
>   In original flow, if we put this memory range into cache_types function.
>   The first round check will update the range to 0x0000 ~ 0x1000
>   Then it won't hit the 0x0000 ~ 0x0FFF MTRR and set the DEFAULT flag to identify the usage of default MTRR.
> 
> Regards,
> Stan Hung
> 
> 
> 
Thanks Stan

Acked-by: Colin Ian King <colin.king at canonical.com>



More information about the fwts-devel mailing list