ACK: [PATCH] acpi: fadt: allow first reserved field to be 1

ivanhu ivan.hu at canonical.com
Tue Jun 5 02:38:52 UTC 2018



On 05/30/2018 03:09 PM, Alex Hung wrote:
> The first reserved field was originally INT_MODEL but was depreciated in
> ACPI 2.0; however, ACPI spec still allows this field to be 1 to maintain
> compatibility.
>
> Signed-off-by: Alex Hung <alex.hung at canonical.com>
> ---
>  src/acpi/fadt/fadt.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/src/acpi/fadt/fadt.c b/src/acpi/fadt/fadt.c
> index 93a5862..8779a51 100644
> --- a/src/acpi/fadt/fadt.c
> +++ b/src/acpi/fadt/fadt.c
> @@ -395,6 +395,9 @@ static void acpi_table_check_fadt_reserved(fwts_framework *fw)
>  {
>  	if (fadt->reserved == (uint8_t)0)
>  		fwts_passed(fw, "FADT first reserved field is zero.");
> +	else if (fadt->reserved == (uint8_t)1)
> +		fwts_passed(fw, "FADT first reserved field is one "
> +			        "(compatible with ACPI 1.0).");
>  	else
>  		fwts_failed(fw, LOG_LEVEL_MEDIUM, "FADTReservedZero",
>  			    "FADT first reserved field is not zero: 0x%02x",

Acked-by: Ivan Hu <ivan.hu at canonical.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/fwts-devel/attachments/20180605/ad35f281/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/fwts-devel/attachments/20180605/ad35f281/attachment.sig>


More information about the fwts-devel mailing list