ACK: [PATCH 5/7] lib: fwts_coreboot_cbmem.c: initialize all fields in array of structs

ivanhu ivan.hu at canonical.com
Tue Jul 31 07:50:17 UTC 2018



On 07/31/2018 02:30 AM, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
>
> This gcc'ism needs to be changed so that clang will cleanly build
> without warnings.
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>  src/lib/src/fwts_coreboot_cbmem.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/lib/src/fwts_coreboot_cbmem.c b/src/lib/src/fwts_coreboot_cbmem.c
> index ae9276d9..3add0871 100644
> --- a/src/lib/src/fwts_coreboot_cbmem.c
> +++ b/src/lib/src/fwts_coreboot_cbmem.c
> @@ -267,7 +267,7 @@ static ssize_t memconsole_coreboot_read(struct cbmem_console *con, char *buf, si
>  	struct seg {	/* describes ring buffer segments in logical order */
>  		uint32_t phys;	/* physical offset from start of mem buffer */
>  		uint32_t len;	/* length of segment */
> -	} seg[2] = { {0}, {0} };
> +	} seg[2] = { { 0, 0 }, { 0, 0 } };
>  	size_t done = 0;
>  	unsigned int i;
>  
Acked-by: Ivan Hu <ivan.hu at canonical.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/fwts-devel/attachments/20180731/ac58e49f/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/fwts-devel/attachments/20180731/ac58e49f/attachment.sig>


More information about the fwts-devel mailing list