ACK: [PATCH] acpi: pptt: Fix PPTTBadSubtableLength error message

Colin Ian King colin.king at canonical.com
Tue Jul 3 09:17:41 UTC 2018


On 21/06/18 20:50, Jeffrey Hugo wrote:
> The PPTTBadSubtableLength error message outputs both what the table
> length is, and what it should be.  However, the printed values are
> flipped.  The "should be" value is printed as what was read, and vice
> versa.
> 
> Correct the value ordering so that the error message provides accurate
> information.
> 
> Signed-off-by: Jeffrey Hugo <jhugo at codeaurora.org>
> ---
>  src/acpi/pptt/pptt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/acpi/pptt/pptt.c b/src/acpi/pptt/pptt.c
> index 7668974..c2a301f 100644
> --- a/src/acpi/pptt/pptt.c
> +++ b/src/acpi/pptt/pptt.c
> @@ -155,7 +155,7 @@ static int pptt_test1(fwts_framework *fw)
>  				"PPTTBadSubtableLength",
>  				"PPTT subtable Type 0x%2.2" PRIx8 " should have "
>  				"length 0x%2.2" PRIx8 ", got 0x%2.2" PRIx8,
> -				entry->type, entry->length, type_length);
> +				entry->type, type_length, entry->length);
>  			break;
>  		}
>  
> 
Good catch!

Acked-by: Colin Ian King <colin.king at canonical.com>



More information about the fwts-devel mailing list