ACK: [PATCH] fwts-test: sync up with changes in lpit test
ivanhu
ivan.hu at canonical.com
Wed Jan 24 07:20:06 UTC 2018
On 01/24/2018 12:01 PM, Alex Hung wrote:
> Signed-off-by: Alex Hung <alex.hung at canonical.com>
> ---
> fwts-test/lpit-0001/acpidump-0001.log | 21 +++++++++---------
> fwts-test/lpit-0001/acpidump-0002.log | 21 +++++++++---------
> fwts-test/lpit-0001/lpit-0001.log | 4 ++--
> fwts-test/lpit-0001/lpit-0002.log | 40 +++++++++++++++++++++++------------
> 4 files changed, 51 insertions(+), 35 deletions(-)
>
> diff --git a/fwts-test/lpit-0001/acpidump-0001.log b/fwts-test/lpit-0001/acpidump-0001.log
> index 51440a6..1910df2 100644
> --- a/fwts-test/lpit-0001/acpidump-0001.log
> +++ b/fwts-test/lpit-0001/acpidump-0001.log
> @@ -24,13 +24,14 @@ FACP @ 0x00000000
> 00f0: 00 00 00 00 ....
>
> LPIT @ 0x00000000
> - 0000: 4c 50 49 54 94 00 00 00 01 20 41 4d 44 20 20 20 SLIT............
> - 0010: 41 47 45 53 41 20 20 20 01 00 00 00 41 4d 44 20 ................
> - 0020: 01 00 00 00 00 00 00 00 38 00 00 00 ad de 00 00 ................
> - 0030: 00 00 00 00 7f 40 00 00 80 70 60 50 40 30 20 10 ................
> - 0040: 11 00 00 00 20 00 00 00 7f 40 00 00 80 70 60 50 ................
> - 0050: 40 30 20 10 a0 b0 00 00 00 00 00 00 00 00 00 00 ................
> - 0060: 38 00 00 00 ef be 00 00 02 00 00 00 7f 40 00 00 ................
> - 0070: 80 70 60 50 40 30 20 f0 23 00 00 00 70 00 00 00
> - 0080: 7f 40 00 00 f0 70 60 50 40 30 20 f0 a0 b0 00 00
> - 0090: 00 00 00 00
> + 0000: 4c 50 49 54 94 00 00 00 01 c6 41 4d 44 20 20 20 LPIT......AMD
> + 0010: 41 47 45 53 41 20 20 20 01 00 00 00 49 4e 54 4c AGESA ....INTL
> + 0020: 05 01 18 20 00 00 00 00 38 00 00 00 00 00 00 00 ... ....8.......
> + 0030: 00 00 00 00 7f 40 00 00 80 70 60 50 40 30 20 10 ..... at ...p`P at 0 .
> + 0040: 11 00 00 00 20 00 00 00 7f 40 00 00 80 70 60 50 .... .... at ...p`P
> + 0050: 40 30 20 10 a0 b0 00 00 00 00 00 00 00 00 00 00 @0 .............
> + 0060: 38 00 00 00 01 00 00 00 02 00 00 00 7f 40 00 00 8............ at ..
> + 0070: 80 70 60 50 40 30 20 f0 23 00 00 00 70 00 00 00 .p`P at 0 .#...p...
> + 0080: 7f 40 00 00 f0 70 60 50 40 30 20 f0 a0 b0 00 00 . at ...p`P at 0 .....
> + 0090: 00 00 00 00 ....
> +
> diff --git a/fwts-test/lpit-0001/acpidump-0002.log b/fwts-test/lpit-0001/acpidump-0002.log
> index 5f4b3ee..d2125ab 100644
> --- a/fwts-test/lpit-0001/acpidump-0002.log
> +++ b/fwts-test/lpit-0001/acpidump-0002.log
> @@ -24,13 +24,14 @@ FACP @ 0x00000000
> 00f0: 00 00 00 00 ....
>
> LPIT @ 0x00000000
> - 0000: 4c 50 49 54 94 00 00 00 01 20 41 4d 44 20 20 20 SLIT............
> - 0010: 41 47 45 53 41 20 20 20 01 00 00 00 41 4d 44 20 ................
> - 0020: 01 00 00 00 00 00 00 00 38 00 00 00 ad de ff ff ................
> - 0030: fd ff 00 00 7f 40 00 00 80 70 60 50 40 30 20 10 ................
> - 0040: 11 00 00 00 20 00 00 00 7f 10 00 00 80 70 60 50 ................
> - 0050: 40 30 20 10 a0 b0 00 00 00 00 00 00 00 00 00 00 ................
> - 0060: 30 00 00 00 ef be 00 00 02 00 00 00 7f 40 00 00 ................
> - 0070: 80 70 60 50 40 30 20 f0 23 00 00 00 70 00 00 00
> - 0080: 7f 40 00 00 f0 70 60 50 40 30 20 f0 a0 b0 00 00
> - 0090: 00 00 00 00
> + 0000: 4c 50 49 54 94 00 00 00 01 f2 41 4d 44 20 20 20 LPIT......AMD
> + 0010: 41 47 45 53 41 20 20 20 01 00 00 00 49 4e 54 4c AGESA ....INTL
> + 0020: 05 01 18 20 00 00 00 00 38 00 00 00 01 00 00 00 ... ....8.......
> + 0030: 01 00 00 00 7f 40 00 00 80 70 60 50 40 30 20 10 ..... at ...p`P at 0 .
> + 0040: 11 00 00 00 20 00 00 00 7f 10 00 00 80 70 60 50 .... ........p`P
> + 0050: 40 30 20 10 a0 b0 00 00 00 00 00 00 00 00 00 00 @0 .............
> + 0060: 38 00 00 00 03 00 00 00 02 00 00 00 7f 40 00 00 8............ at ..
> + 0070: 80 70 60 50 40 30 20 f0 23 00 00 00 70 00 00 00 .p`P at 0 .#...p...
> + 0080: 7f 40 00 00 f0 70 60 50 40 30 20 f0 a0 b0 00 00 . at ...p`P at 0 .....
> + 0090: 00 00 00 00 ....
> +
> diff --git a/fwts-test/lpit-0001/lpit-0001.log b/fwts-test/lpit-0001/lpit-0001.log
> index 445d4e3..e273b64 100644
> --- a/fwts-test/lpit-0001/lpit-0001.log
> +++ b/fwts-test/lpit-0001/lpit-0001.log
> @@ -4,7 +4,7 @@ lpit Test 1 of 1: LPIT Low Power Idle Table test.
> lpit Native C-state based LPI structure:
> lpit Type: 0x00000000
> lpit Length: 0x00000038
> -lpit ID: 0xdead
> +lpit ID: 0x0000
> lpit Reserved: 0x0000
> lpit Flags: 0x00000000
> lpit Entry Trigger:
> @@ -26,7 +26,7 @@ lpit
> lpit Native C-state based LPI structure:
> lpit Type: 0x00000000
> lpit Length: 0x00000038
> -lpit ID: 0xbeef
> +lpit ID: 0x0001
> lpit Reserved: 0x0000
> lpit Flags: 0x00000002
> lpit Entry Trigger:
> diff --git a/fwts-test/lpit-0001/lpit-0002.log b/fwts-test/lpit-0001/lpit-0002.log
> index 4e29206..57172fd 100644
> --- a/fwts-test/lpit-0001/lpit-0002.log
> +++ b/fwts-test/lpit-0001/lpit-0002.log
> @@ -4,9 +4,9 @@ lpit Test 1 of 1: LPIT Low Power Idle Table test.
> lpit Native C-state based LPI structure:
> lpit Type: 0x00000000
> lpit Length: 0x00000038
> -lpit ID: 0xdead
> -lpit Reserved: 0xffff
> -lpit Flags: 0x0000fffd
> +lpit ID: 0x0001
> +lpit Reserved: 0x0000
> +lpit Flags: 0x00000001
> lpit Entry Trigger:
> lpit Address Space ID: 0x7f
> lpit Register Bit Width 0x40
> @@ -23,23 +23,37 @@ lpit Access Size 0x00
> lpit Address 0x1020304050607080
> lpit Residency Counter Freq: 0x000000000000b0a0
> lpit
> -lpit FAILED [MEDIUM] LPITReservedNonZero: Test 1, LPIT Native
> -lpit C-state based LPI structure reserved field must be zero,
> -lpit got 0xffff instead
> -lpit FAILED [HIGH] LPITReservedBitsNonZero: Test 1, LPIT LPI
> -lpit structure flags Bits [31..2] must be zero, got 0x0000fffd
> -lpit instead
> lpit FAILED [LOW] LPITNativeCStateLpitResidencyCounterWidth:
> lpit Test 1, Native C-state based LPI structure Residency
> lpit Structure Register Bit Width was 16 for a FFH Address
> lpit Space (e.g. a MSR), and was expecting 64.
> lpit
> +lpit FAILED [CRITICAL] LPITNativeCStateBadUID: Test 1, Unique
> +lpit ID of Native C-state based LPI structure must start from
> +lpit zero
> lpit Native C-state based LPI structure:
> lpit Type: 0x00000000
> -lpit Length: 0x00000030
> -lpit FAILED [HIGH] LPITNativeCStateLpitShort: Test 1, Native
> -lpit C-state based LPI structure is too short, got 48 bytes,
> -lpit expected 56 bytes
> +lpit Length: 0x00000038
> +lpit ID: 0x0003
> +lpit Reserved: 0x0000
> +lpit Flags: 0x00000002
> +lpit Entry Trigger:
> +lpit Address Space ID: 0x7f
> +lpit Register Bit Width 0x40
> +lpit Register Bit Offset 0x00
> +lpit Access Size 0x00
> +lpit Address 0xf020304050607080
> +lpit Residency: 0x00000023
> +lpit Latency: 0x00000070
> +lpit Residency Counter not available
> +lpit
> +lpit
> +lpit FAILED [CRITICAL] LPITNativeCStateBadUID: Test 1, Unique
> +lpit ID of Native C-state based LPI structure must start from
> +lpit zero
> +lpit FAILED [CRITICAL] LPITNativeCStateBadUID: Test 1, Unique
> +lpit ID of Native C-state based LPI structure must be a
> +lpit zero-based monotonically increasing value
> lpit
> lpit ==========================================================
> lpit 0 passed, 4 failed, 0 warning, 0 aborted, 0 skipped, 0
>
Acked-by: Ivan Hu <ivan.hu at canonical.com>
More information about the fwts-devel
mailing list