ACK: [PATCH] opal: reserve_mem: remove redundant initialization of pointer p

ivanhu ivan.hu at canonical.com
Wed Jan 24 07:08:53 UTC 2018



On 01/23/2018 08:13 PM, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
> 
> Pointer p is initialized to NULL however this value is never read
> as p is assigned the return from malloc immediately afterwards.
> Remove the redundant assignment.
> 
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>   src/opal/reserv_mem.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/opal/reserv_mem.c b/src/opal/reserv_mem.c
> index ea528082..f31e9652 100644
> --- a/src/opal/reserv_mem.c
> +++ b/src/opal/reserv_mem.c
> @@ -92,7 +92,7 @@ static int get_config(fwts_framework *fw,
>   
>   static char *make_message(const char *fmt, ...)
>   {
> -	char *p = NULL;
> +	char *p;
>   	const size_t size = 128;
>   	va_list ap;
>   
> 

Acked-by: Ivan Hu <ivan.hu at canonical.com>



More information about the fwts-devel mailing list