ACK: [PATCH] lib: fwts_alloc: move 'pos' to a deeper scope, minor style change

[ivanhu]

On 01/23/2018 08:10 PM, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
> 
> Move variable pos into the loop scope, cleans up a cppcheck style
> warning; trivial change.
> 
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>   src/lib/src/fwts_alloc.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/lib/src/fwts_alloc.c b/src/lib/src/fwts_alloc.c
> index 5ddbe619..50637a78 100644
> --- a/src/lib/src/fwts_alloc.c
> +++ b/src/lib/src/fwts_alloc.c
> @@ -239,7 +239,7 @@ static void *fwts_low_mmap(const size_t requested_size)
>   	void *last_addr_end = NULL;
>   	void *first_addr_start = NULL;
>   	void *ret = MAP_FAILED;
> -	long pos, prev_pos = 0;
> +	long prev_pos = 0;
>   
>   	if (requested_size == 0)	/* Illegal */
>   		return MAP_FAILED;
> @@ -254,6 +254,7 @@ static void *fwts_low_mmap(const size_t requested_size)
>   
>   	while (!feof(fp)) {
>   		int n;
> +		long pos;
>   
>   		n = fscanf(fp, "%p-%p %*s %*x %*s %*u %1023s\n",
>   		    &addr_start, &addr_end, pathname);
> 

Acked-by: Ivan Hu <ivan.hu at canonical.com>