ACK: [PATCH] acpi: acpidump: move declaration to before statements, add blank lines

Alex Hung alex.hung at canonical.com
Wed Jan 24 03:39:25 UTC 2018


On 2018-01-23 03:53 AM, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
> 
> Just some code style changes, no functional change
> 
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>   src/acpi/acpidump/acpidump.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/acpi/acpidump/acpidump.c b/src/acpi/acpidump/acpidump.c
> index ecf85bd9..8b596f13 100644
> --- a/src/acpi/acpidump/acpidump.c
> +++ b/src/acpi/acpidump/acpidump.c
> @@ -167,10 +167,11 @@ static int acpidump_test1(fwts_framework *fw)
>   			acpi_dump_raw_table(fw, table);
>   		} else {
>   			/* Successfully disassembled, so parse */
> +			fwts_list_link *line;
>   
>   			bool skip = false;
>   			bool unknown = false;
> -			fwts_list_link *line;
> +
>   			fwts_list_foreach(line, output) {
>   				char *text = fwts_text_list_text(line);
>   				bool ignore = (strstr(text, "Raw Table Data:") != NULL);
> 


Acked-by: Alex Hung <alex.hung at canonical.com>



More information about the fwts-devel mailing list