[PATCH] sbbr: rsdp: remove redundant initialization of boolean 'signature_pass'
Colin King
colin.king at canonical.com
Tue Jan 23 12:19:45 UTC 2018
From: Colin Ian King <colin.king at canonical.com>
Boolean variable signature_pass is being initialized however this value is
never read as it is being re-assigned a few lines later with the return
from of strcmp. Hence is it redundant and can be removed. Cleans up
a static analysis warning.
Signed-off-by: Colin Ian King <colin.king at canonical.com>
---
src/sbbr/rsdp/rsdp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/sbbr/rsdp/rsdp.c b/src/sbbr/rsdp/rsdp.c
index 2ca6e958..775f1eba 100644
--- a/src/sbbr/rsdp/rsdp.c
+++ b/src/sbbr/rsdp/rsdp.c
@@ -70,7 +70,7 @@ static int rsdp_sbbr_test1(fwts_framework *fw)
* zero.
*/
static const char RSDP_SIGNATURE[] = {'R', 'S', 'D', ' ', 'P', 'T', 'R', ' '};
- bool signature_pass = false;
+ bool signature_pass;
bool checksum_pass = false;
bool rsdp_revision_pass = false;
bool rsdp_length_pass = false;
--
2.15.1
More information about the fwts-devel
mailing list