ACK: [PATCH] acpi: iort: Update revision checking

Jeffrey Hugo jhugo at codeaurora.org
Wed Feb 14 19:11:07 UTC 2018


On 2/14/2018 11:57 AM, Alex Hung wrote:
> On 2018-02-14 06:55 AM, Jeffrey Hugo wrote:
>> The IORT spec revC updated node types 1, 3, and 4 to revision 1, from
>> revision 0.  Update the revision checking to allow these node types to
>> have either revision 0 or revision 1.
>>
>> Signed-off-by: Jeffrey Hugo <jhugo at codeaurora.org>
>> ---
>>   src/acpi/iort/iort.c | 12 +++++++++++-
>>   1 file changed, 11 insertions(+), 1 deletion(-)
>>
>> diff --git a/src/acpi/iort/iort.c b/src/acpi/iort/iort.c
>> index 17ab1dc..a3a9a5a 100644
>> --- a/src/acpi/iort/iort.c
>> +++ b/src/acpi/iort/iort.c
>> @@ -74,7 +74,17 @@ static void iort_node_check(
>>   {
>>       fwts_acpi_table_iort_node *node = (fwts_acpi_table_iort_node 
>> *)data;
>> -    if (node->revision != 0) {
>> +    if (node->type == 1 || node->type == 3 || node->type == 4) {
>> +        if (node->revision > 1) {
>> +            *passed = false;
>> +            fwts_failed(fw, LOG_LEVEL_LOW,
>> +                "IORTNodeRevisionInvalid",
>> +                "IORT Node Revision field is 0x%2.2" PRIx8
>> +                " and should be zero or one.",
>> +                node->revision);
>> +        }
> 
> There is a trailing space here, but I think Ivan should be able to 
> manually fix it when applying.
> 
>> +

Drat, I didn't mean to have this blank line here either.  Looks like I 
didn't completely commit the whitespace fixes.

Let me know if you'd prefer I send a V2 with both of these fixed.

>> +    } else if (node->revision != 0) {
>>           *passed = false;
>>           fwts_failed(fw, LOG_LEVEL_LOW,
>>               "IORTNodeRevisionNonZero",
>>
> 
> 
> Acked-by: Alex Hung <alex.hung at canonical.com>
> 


-- 
Jeffrey Hugo
Qualcomm Datacenter Technologies as an affiliate of Qualcomm 
Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.



More information about the fwts-devel mailing list