ACK: [PATCH] lib: fwts_acpi_tables: remove redundant initialization to 'result'

Alex Hung alex.hung at canonical.com
Fri Feb 2 02:49:55 UTC 2018


On 2018-01-31 02:28 AM, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
> 
> Variable 'result' is going to be over-written later, so there is no
> need to initialize it, remove the redundant initialization.
> 
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>   src/lib/src/fwts_acpi_tables.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/lib/src/fwts_acpi_tables.c b/src/lib/src/fwts_acpi_tables.c
> index c966edd6..2aa30f80 100644
> --- a/src/lib/src/fwts_acpi_tables.c
> +++ b/src/lib/src/fwts_acpi_tables.c
> @@ -378,7 +378,7 @@ static int fwts_acpi_handle_fadt(
>   	const fwts_acpi_table_provenance provenance)
>   {
>   	static uint64_t	facs_last_phys_addr;	/* default to zero */
> -	int result = FWTS_ERROR;
> +	int result;
>   
>   	/*
>   	 *  The FADT handling may occur twice if it appears
> 

Acked-by: Alex Hung <alex.hung at canonical.com>



More information about the fwts-devel mailing list