ACK: [PATCH 21/27] bios: mtrr make function multi_types_check static

[ivanhu]

On 08/15/2018 09:11 PM, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
>
> Function multi_types_check is local to the source and does not
> need to be in the global namespace so make it static. Also remove
> redundant voidification of function return.
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>  src/bios/mtrr/mtrr.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/bios/mtrr/mtrr.c b/src/bios/mtrr/mtrr.c
> index ecd6204e..5dfb4a60 100644
> --- a/src/bios/mtrr/mtrr.c
> +++ b/src/bios/mtrr/mtrr.c
> @@ -360,7 +360,7 @@ static int guess_cache_type(
>  	return FWTS_OK;
>  }
>  
> -void multi_types_check(fwts_framework *fw, int *type)
> +static void multi_types_check(fwts_framework *fw, int *type)
>  {
>  	int n_types = 0, i;
>  
> @@ -463,7 +463,7 @@ static int validate_iomem(fwts_framework *fw)
>  
>  		type = cache_types(start, end);
>  
> -		(void)multi_types_check(fw, &type);
> +		multi_types_check(fw, &type);
>  
>  		if (guess_cache_type(fw, c2, &type_must, &type_mustnot, start) != FWTS_OK) {
>  			/*  This has failed, give up at this point */

Acked-by: Ivan Hu <ivan.hu at canonical.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/fwts-devel/attachments/20180816/c8a7c22a/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/fwts-devel/attachments/20180816/c8a7c22a/attachment.sig>