ACK: [PATCH 07/27] lib: fwts_log_scan: rename function argument to avoid name shadowing

[ivanhu]

On 08/15/2018 09:11 PM, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
>
> The argument fwts_log_scan_patterns to function fwts_log_check is
> shadowing the global function of the same name.  Rename the function
> argument to avoid name shadowing confusion.
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>  src/lib/src/fwts_log_scan.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/lib/src/fwts_log_scan.c b/src/lib/src/fwts_log_scan.c
> index 9a2f0f95..2a2460e2 100644
> --- a/src/lib/src/fwts_log_scan.c
> +++ b/src/lib/src/fwts_log_scan.c
> @@ -349,7 +349,7 @@ nullobj:
>  
>  int fwts_log_check(fwts_framework *fw,
>          const char *table,
> -        fwts_log_scan_func fwts_log_scan_patterns,
> +        fwts_log_scan_func fwts_log_scan_patterns_func,
>          fwts_log_progress_func progress,
>          fwts_list *log,
>          int *errors,
> @@ -450,7 +450,7 @@ int fwts_log_check(fwts_framework *fw,
>                  }
>          }
>          /* We've now collected up the scan patterns, lets scan the log for errors */
> -        ret = fwts_log_scan(fw, log, fwts_log_scan_patterns, progress, patterns, errors, remove_timestamp);
> +        ret = fwts_log_scan(fw, log, fwts_log_scan_patterns_func, progress, patterns, errors, remove_timestamp);
>  
>  fail:
>          for (i = 0; i < n; i++) {

Acked-by: Ivan Hu <ivan.hu at canonical.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/fwts-devel/attachments/20180816/d108e910/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/fwts-devel/attachments/20180816/d108e910/attachment-0001.sig>