ACK: [PATCH 01/27] lib: fwts_framework: ensure src pointer is const

ivanhu ivan.hu at canonical.com
Thu Aug 16 09:11:08 UTC 2018


On 08/15/2018 09:11 PM, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
>
> We are reading src from a const static string, so make src
> pointer const char *.
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>  src/lib/src/fwts_framework.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/lib/src/fwts_framework.c b/src/lib/src/fwts_framework.c
> index f6e7b72e..60b9bd66 100644
> --- a/src/lib/src/fwts_framework.c
> +++ b/src/lib/src/fwts_framework.c
> @@ -286,7 +286,8 @@ static void fwts_framework_show_tests_categories(void)
>  
>  		for (i = 0; categories[i].title != NULL; i++) {
>  			if (categories[i].flag & test->flags) {
> -				char *src = (char *)categories[i].title, *dst;
> +				const char *src = (const char *)categories[i].title;
> +				char *dst;
>  				size_t len = strlen(src) + 1;
>  				char buf[len];
>  

Acked-by: Ivan Hu <ivan.hu at canonical.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/fwts-devel/attachments/20180816/19bed96e/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/fwts-devel/attachments/20180816/19bed96e/attachment.sig>


More information about the fwts-devel mailing list