ACK: [PATCH 09/13] lib: fwts_list: some minor fwts coding style changes

ivanhu ivan.hu at canonical.com
Thu Aug 16 09:05:09 UTC 2018



On 08/14/2018 07:24 PM, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
>
> No functional change.
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>  src/lib/src/fwts_list.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/lib/src/fwts_list.c b/src/lib/src/fwts_list.c
> index dd870e3a..8fd7ea04 100644
> --- a/src/lib/src/fwts_list.c
> +++ b/src/lib/src/fwts_list.c
> @@ -85,7 +85,7 @@ fwts_list_link *fwts_list_append(fwts_list *list, void *data)
>  	if (!list)
>  		return NULL;
>  
> -	if ((link = calloc(1,sizeof(fwts_list_link))) == NULL)
> +	if ((link = calloc(1, sizeof(fwts_list_link))) == NULL)
>  		return NULL;
>  
>  	link->data = data;
> @@ -117,6 +117,7 @@ fwts_list_link *fwts_list_add_ordered(fwts_list *list, void *new_data, fwts_list
>  
>  	for (list_item = &list->head; *list_item; list_item = &(*list_item)->next) {
>  		void *data = (void *)(*list_item)->data;
> +
>  		if (compare(data, new_data) >= 0) {
>  			new_list_item->next = (*list_item);
>  			break;

Acked-by: Ivan Hu <ivan.hu at canonical.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/fwts-devel/attachments/20180816/315ccf16/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/fwts-devel/attachments/20180816/315ccf16/attachment.sig>


More information about the fwts-devel mailing list