ACK: [PATCH 24/27] uefi: uefirtauthvar: rename argument attibutes to var_attributes

Alex Hung alex.hung at canonical.com
Wed Aug 15 18:12:04 UTC 2018


On 2018-08-15 06:11 AM, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
> 
> Argument attibutes shadows the global variable name attibutes
> so rename it to var_attributes to avoid any variable shadowing
> confusion
> 
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>   src/uefi/uefirtauthvar/uefirtauthvar.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/uefi/uefirtauthvar/uefirtauthvar.c b/src/uefi/uefirtauthvar/uefirtauthvar.c
> index c59b0879..606bead7 100644
> --- a/src/uefi/uefirtauthvar/uefirtauthvar.c
> +++ b/src/uefi/uefirtauthvar/uefirtauthvar.c
> @@ -56,7 +56,7 @@ static uint16_t variablenametest[] = {'A', 'u', 't', 'h', 'V', 'a', 'r', 'T', 'e
>   
>   static long setvar(
>   	EFI_GUID *guid,
> -	uint32_t attributes,
> +	uint32_t var_attributes,
>   	uint64_t datasize,
>   	void *data,
>   	uint64_t *status)
> @@ -66,7 +66,7 @@ static long setvar(
>   
>   	setvariable.VariableName = variablenametest;
>   	setvariable.VendorGuid = guid;
> -	setvariable.Attributes = attributes;
> +	setvariable.Attributes = var_attributes;
>   	setvariable.DataSize = datasize;
>   	setvariable.Data = data;
>   	setvariable.status = status;
> 



Acked-by: Alex Hung <alex.hung at canonical.com>



More information about the fwts-devel mailing list