ACK: [PATCH 12/27] sbbr: acpitables: make function sbbr_search_acpi_tables static

Alex Hung alex.hung at canonical.com
Wed Aug 15 18:10:22 UTC 2018


On 2018-08-15 06:11 AM, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
> 
> Function sbbr_search_acpi_tables is local to the source and
> does not need to be in the global namespace so make it static
> 
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>   src/sbbr/acpitables/acpitables.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/sbbr/acpitables/acpitables.c b/src/sbbr/acpitables/acpitables.c
> index e6786eec..0f83747a 100644
> --- a/src/sbbr/acpitables/acpitables.c
> +++ b/src/sbbr/acpitables/acpitables.c
> @@ -214,7 +214,7 @@ static const char *recommended_acpi_tables[] = {
>   };
>   
>   /* Searches ACPI tables by signature. */
> -fwts_acpi_table_info *sbbr_search_acpi_tables(fwts_framework *fw, const char *signature)
> +static fwts_acpi_table_info *sbbr_search_acpi_tables(fwts_framework *fw, const char *signature)
>   {
>   	uint32_t i;
>   	fwts_acpi_table_info *info;
> 



Acked-by: Alex Hung <alex.hung at canonical.com>



More information about the fwts-devel mailing list