ACK: [PATCH 06/27] lib: fwts_safe_mem: add in missing constifications

Alex Hung alex.hung at canonical.com
Wed Aug 15 17:55:02 UTC 2018


On 2018-08-15 06:11 AM, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
> 
> The pointers are const, so ensure the pointer casting is const too.
> 
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>   src/lib/src/fwts_safe_mem.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/lib/src/fwts_safe_mem.c b/src/lib/src/fwts_safe_mem.c
> index 10d4f7c5..a177a00b 100644
> --- a/src/lib/src/fwts_safe_mem.c
> +++ b/src/lib/src/fwts_safe_mem.c
> @@ -104,7 +104,7 @@ int OPTIMIZE0 fwts_safe_memread(const void *src, const size_t n)
>   int OPTIMIZE0 fwts_safe_memread32(const void *src, const size_t n)
>   {
>   	static uint32_t buffer[256];
> -	const uint32_t *ptr, *end = (uint32_t *)src + n;
> +	const uint32_t *ptr, *end = (const uint32_t *)src + n;
>   	uint32_t *bufptr;
>   	const uint32_t *bufend = buffer + (sizeof(buffer) / sizeof(*buffer));
>   
> @@ -139,7 +139,7 @@ int OPTIMIZE0 fwts_safe_memread32(const void *src, const size_t n)
>   int OPTIMIZE0 fwts_safe_memread64(const void *src, const size_t n)
>   {
>   	static uint64_t buffer[256];
> -	const uint64_t *ptr, *end = (uint64_t *)src + n;
> +	const uint64_t *ptr, *end = (const uint64_t *)src + n;
>   	uint64_t *bufptr;
>   	const uint64_t *bufend = buffer + (sizeof(buffer) / sizeof(*buffer));
>   
> 

Acked-by: Alex Hung <alex.hung at canonical.com>



More information about the fwts-devel mailing list