ACK: [PATCH] lib/src/fwts_acpi_tables: remove shadowed pointer ptr

Alex Hung alex.hung at canonical.com
Wed Aug 15 16:40:25 UTC 2018


On 2018-08-15 02:57 AM, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
> 
> Pointer 'ptr' can be removed as it is a shadow of a previously
> declared pointer with the same name and we don't need another
> copy of one of the same name.
> 
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>   src/lib/src/fwts_acpi_tables.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/src/lib/src/fwts_acpi_tables.c b/src/lib/src/fwts_acpi_tables.c
> index f28ed60a..ccf0a7b1 100644
> --- a/src/lib/src/fwts_acpi_tables.c
> +++ b/src/lib/src/fwts_acpi_tables.c
> @@ -595,7 +595,6 @@ static uint8_t *fwts_acpi_load_table_from_acpidump(
>   	 */
>   	while (fgets(buffer, sizeof(buffer), fp) ) {
>   		uint8_t *new_tmp;
> -		char *ptr;
>   		int n;
>   
>   		/* Get offset */
> 

Acked-by: Alex Hung <alex.hung at canonical.com>



More information about the fwts-devel mailing list