[PATCH 00/27] various trivial warning fixes

Colin King colin.king at canonical.com
Wed Aug 15 13:11:02 UTC 2018


From: Colin Ian King <colin.king at canonical.com>

These are trivial fixes to warnings found when building with various
extra gcc pedantic flags.

Colin Ian King (27):
  lib: fwts_framework: ensure src pointer is const
  fwts_framework: no need to pass tests_to_skip as it is locally scoped
  lib: fwts_framework: argument 'arg' should not be const
  lib: fwts_log: remove const arg in fwts_log_set_field_filter
  lib: fwts_summary: remove redundant redefinition of
    fwts_summary_deinit
  lib: fwts_safe_mem: add in missing constifications
  lib: fwts_log_scan: rename function argument to avoid name shadowing
  lib: fwts_stringextras: fix some missing constifictions
  lib: fwts_text_list: fix up some const casting issues
  lib: fwts_json.h: fix casting warning, add missing const
  lib: fwts_coreboot_cbmen: fix missing const in cast
  sbbr: acpitables: make function sbbr_search_acpi_tables static
  acpi: crsdump: add in missing pointer constifications
  acpi: ecdt: fix some missing pointer constifications
  acpi: fadt: add in missing const to fix build warnings
  sbbr: fadt: add in missing const to fix build warnings
  acpi: method: make function method_test_CRS_return static
  acpi: nfit: rename table to nfit_table to avoid name shadowing
  acpi: wmi: add in missing const to fix build warnings
  acpi: stao: add in missing const to fix build warnings
  bios: mtrr make function multi_types_check static
  opal: reserv_mem: add in missing const to fix build warnings
  hotkey: rename list 'hotkeys' to avoid name shadowing
  uefi: uefirtauthvar: rename argument attibutes to var_attributes
  uefi: uefirtvariable: rename argument attibutes to var_attributes
  coreboot: clog: rename list 'clog' to avoid name shadowing
  lib: fwts_acpi_tables: unconstify data and don't strcpy ACPI table ids

 src/acpi/crsdump/crsdump.c               | 10 +++----
 src/acpi/ecdt/ecdt.c                     |  8 +++---
 src/acpi/fadt/fadt.c                     | 32 +++++++++++------------
 src/acpi/method/method.c                 |  2 +-
 src/acpi/nfit/nfit.c                     | 14 +++++-----
 src/acpi/stao/stao.c                     | 16 ++++++------
 src/acpi/wmi/wmi.c                       |  4 +--
 src/bios/mtrr/mtrr.c                     |  4 +--
 src/coreboot/clog/clog.c                 | 11 ++++----
 src/hotkey/hotkey/hotkey.c               |  8 +++---
 src/lib/include/fwts_acpi_tables.h       |  2 +-
 src/lib/include/fwts_json.h              |  2 +-
 src/lib/include/fwts_log.h               |  2 +-
 src/lib/include/fwts_stringextras.h      |  2 +-
 src/lib/src/fwts_acpi_tables.c           | 24 ++++++++---------
 src/lib/src/fwts_coreboot_cbmem.c        |  2 +-
 src/lib/src/fwts_framework.c             | 33 ++++++++++++------------
 src/lib/src/fwts_log.c                   |  4 +--
 src/lib/src/fwts_log_scan.c              |  4 +--
 src/lib/src/fwts_safe_mem.c              |  4 +--
 src/lib/src/fwts_stringextras.c          |  8 +++---
 src/lib/src/fwts_summary.c               |  2 --
 src/lib/src/fwts_text_list.c             |  8 +++---
 src/opal/reserv_mem.c                    |  4 +--
 src/sbbr/acpitables/acpitables.c         |  2 +-
 src/sbbr/fadt/fadt.c                     | 32 +++++++++++------------
 src/uefi/uefirtauthvar/uefirtauthvar.c   |  4 +--
 src/uefi/uefirtvariable/uefirtvariable.c |  8 +++---
 28 files changed, 127 insertions(+), 129 deletions(-)

-- 
2.17.1




More information about the fwts-devel mailing list