ACK: [PATCH] acpitables: remove redundant "OEM" from Creator ID field

ivanhu ivan.hu at canonical.com
Tue Aug 14 07:44:30 UTC 2018



On 08/10/2018 08:08 AM, Alex Hung wrote:
> "Creator ID" is used in ACPI spec, not "OEM Creator ID". In addition,
> this ID may not be specific to OEM but to IHV or IFV.
> 
> Signed-off-by: Alex Hung <alex.hung at canonical.com>
> ---
>   src/acpi/acpitables/acpitables.c | 2 +-
>   src/sbbr/acpitables/acpitables.c | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/acpi/acpitables/acpitables.c b/src/acpi/acpitables/acpitables.c
> index b11b8e35..6f0b110a 100644
> --- a/src/acpi/acpitables/acpitables.c
> +++ b/src/acpi/acpitables/acpitables.c
> @@ -106,7 +106,7 @@ static int acpi_table_check_test1(fwts_framework *fw)
>   		passed = acpi_table_check_field_test(fw, name, "Signature", hdr->signature, 4) &
>   			 acpi_table_check_field_test(fw, name, "OEM ID", hdr->oem_id, 6) &
>   			 acpi_table_check_field_test(fw, name, "OEM Table ID", hdr->oem_tbl_id, 8) &
> -			 acpi_table_check_field_test(fw, name, "OEM Creator ID", hdr->creator_id, 4);
> +			 acpi_table_check_field_test(fw, name, "Creator ID", hdr->creator_id, 4);
>   		if (passed)
>   			fwts_passed(fw, "Table %s has valid signature and ID strings.", name);
>   
> diff --git a/src/sbbr/acpitables/acpitables.c b/src/sbbr/acpitables/acpitables.c
> index 72ce743c..7d0d1987 100644
> --- a/src/sbbr/acpitables/acpitables.c
> +++ b/src/sbbr/acpitables/acpitables.c
> @@ -176,7 +176,7 @@ static int acpi_table_sbbr_check_test2(fwts_framework *fw)
>   			passed = acpi_table_check_field_test(fw, name, "Signature", hdr->signature, MIN_SIG) &
>   			    acpi_table_check_field_test(fw, name, "OEM ID", hdr->oem_id, OEM_ID) &
>   			    acpi_table_check_field_test(fw, name, "OEM Table ID", hdr->oem_tbl_id, OEM_TABLE_ID) &
> -			    acpi_table_check_field_test(fw, name, "OEM Creator ID", hdr->creator_id, OEM_CREATOR_ID);
> +			    acpi_table_check_field_test(fw, name, "Creator ID", hdr->creator_id, OEM_CREATOR_ID);
>   			if (passed)
>   				fwts_passed(fw, "Table %s has valid signature and ID strings.", name);
>   		}
> 

Acked-by: Ivan Hu <ivan.hu at canonical.com>



More information about the fwts-devel mailing list