[PATCH 1/2] src: remove unnecessary new line characters and trailing spaces

Alex Hung alex.hung at canonical.com
Tue Aug 14 07:40:18 UTC 2018


Signed-off-by: Alex Hung <alex.hung at canonical.com>
---
 src/acpi/acpiinfo/acpiinfo.c         | 2 +-
 src/acpi/apicinstance/apicinstance.c | 2 +-
 src/acpi/fadt/fadt.c                 | 2 +-
 src/acpi/method/method.c             | 2 +-
 src/bios/pciirq/pciirq.c             | 2 +-
 src/bios/pnp/pnp.c                   | 2 +-
 src/cpu/nx/nx.c                      | 2 +-
 src/kernel/olog/olog.c               | 4 ++--
 src/sbbr/fadt/fadt.c                 | 2 +-
 9 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/src/acpi/acpiinfo/acpiinfo.c b/src/acpi/acpiinfo/acpiinfo.c
index 50818503..d3aa6b2a 100644
--- a/src/acpi/acpiinfo/acpiinfo.c
+++ b/src/acpi/acpiinfo/acpiinfo.c
@@ -120,7 +120,7 @@ static int acpiinfo_test2(fwts_framework *fw)
 		minor = fadt->minor_version;
 
 	fwts_log_info(fw,
-		"FACP ACPI Version: %d.%d\n", major, minor);
+		"FACP ACPI Version: %d.%d", major, minor);
 
 	fwts_infoonly(fw);
 
diff --git a/src/acpi/apicinstance/apicinstance.c b/src/acpi/apicinstance/apicinstance.c
index 9cc81d91..d6609239 100644
--- a/src/acpi/apicinstance/apicinstance.c
+++ b/src/acpi/apicinstance/apicinstance.c
@@ -39,7 +39,7 @@ static int apicinstance_test1(fwts_framework *fw)
 			break;
 
 		if (strcmp(table->name, "APIC") == 0)  {
-			fwts_log_info(fw, "Found APIC/MADT table %s @ %llx, length 0x%d\n",
+			fwts_log_info(fw, "Found APIC/MADT table %s @ %llx, length 0x%d",
 				table->name,
 				(unsigned long long)table->addr,
 				(int)table->length);
diff --git a/src/acpi/fadt/fadt.c b/src/acpi/fadt/fadt.c
index 8779a51d..6304d14c 100644
--- a/src/acpi/fadt/fadt.c
+++ b/src/acpi/fadt/fadt.c
@@ -416,7 +416,7 @@ static void acpi_table_check_fadt_reserved(fwts_framework *fw)
 
 static void acpi_table_check_fadt_pm_profile(fwts_framework *fw)
 {
-	fwts_log_info(fw, "FADT Preferred PM Profile: %hhu (%s)\n",
+	fwts_log_info(fw, "FADT Preferred PM Profile: %hhu (%s)",
 		fadt->preferred_pm_profile,
 		FWTS_ACPI_FADT_PREFERRED_PM_PROFILE(fadt->preferred_pm_profile));
 
diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c
index 997a6179..79328306 100644
--- a/src/acpi/method/method.c
+++ b/src/acpi/method/method.c
@@ -472,7 +472,7 @@ static int method_name_check(fwts_framework *fw)
 		fwts_list_link	*item;
 		bool failed = false;
 
-		fwts_log_info(fw, "Found %d Objects\n", methods->len);
+		fwts_log_info(fw, "Found %d Objects", methods->len);
 
 		fwts_list_foreach(item, methods) {
 			char *ptr;
diff --git a/src/bios/pciirq/pciirq.c b/src/bios/pciirq/pciirq.c
index 8187252c..71454d50 100644
--- a/src/bios/pciirq/pciirq.c
+++ b/src/bios/pciirq/pciirq.c
@@ -109,7 +109,7 @@ static int pciirq_test1(fwts_framework *fw)
 		" and described in pages 233-238 of PCI System Architecture, "
 		"Fourth Edition, Mindshare, Inc. (1999). "
 		"NOTE: The PCI IRQ Routing Table only really knows about ISA IRQs "
-		"and is generally not used with APIC. ");
+		"and is generally not used with APIC.");
 
         if ((mem = fwts_mmap(PCIIRQ_REGION_START,
 			PCIIRQ_REGION_SIZE)) == FWTS_MAP_FAILED) {
diff --git a/src/bios/pnp/pnp.c b/src/bios/pnp/pnp.c
index 18702dbf..412a2e1d 100644
--- a/src/bios/pnp/pnp.c
+++ b/src/bios/pnp/pnp.c
@@ -82,7 +82,7 @@ static int pnp_test1(fwts_framework *fw)
 
 	fwts_log_info(fw,
 		"This test tries to find and sanity check the "
-		"Plug and Play BIOS Support Installation Check structure. ");
+		"Plug and Play BIOS Support Installation Check structure.");
 
         if ((mem = fwts_mmap(PNP_REGION_START,
 			PNP_REGION_SIZE)) == FWTS_MAP_FAILED) {
diff --git a/src/cpu/nx/nx.c b/src/cpu/nx/nx.c
index f9d7b7dd..66a7b6f1 100644
--- a/src/cpu/nx/nx.c
+++ b/src/cpu/nx/nx.c
@@ -91,7 +91,7 @@ static int nx_test2(fwts_framework *fw)
 	fwts_log_info(fw,
 		"This test verifies that all CPUs have the same NX flag setting. "
 		"Although rare, BIOS may set the NX flag differently "
-		"per CPU. ");
+		"per CPU.");
 
 	if ((n = fwts_cpu_enumerate()) == FWTS_ERROR) {
 		fwts_log_error(fw, "Cannot determine number of CPUs");
diff --git a/src/kernel/olog/olog.c b/src/kernel/olog/olog.c
index a7aa2296..5040be26 100644
--- a/src/kernel/olog/olog.c
+++ b/src/kernel/olog/olog.c
@@ -39,8 +39,8 @@ static int olog_init(fwts_framework *fw)
 	else {
 		olog = fwts_olog_read(fw);
 		if (olog == NULL) {
-			fwts_log_error(fw, "OLOG without any parameters on the platform you are running does nothing, please specify -o for custom log analysis.\n");
-			fwts_log_error(fw, "PPC supports dump and analysis of the default firmware logs.\n");
+			fwts_log_error(fw, "OLOG without any parameters on the platform you are running does nothing, please specify -o for custom log analysis.");
+			fwts_log_error(fw, "PPC supports dump and analysis of the default firmware logs.");
 			return FWTS_SKIP;
 		}
 	}
diff --git a/src/sbbr/fadt/fadt.c b/src/sbbr/fadt/fadt.c
index 5ecb68c7..430e39da 100644
--- a/src/sbbr/fadt/fadt.c
+++ b/src/sbbr/fadt/fadt.c
@@ -373,7 +373,7 @@ static int fadt_sbbr_profile_test3(fwts_framework *fw)
 	const uint8_t SBBR_SOHO_SERVER  = 5;
 	const uint8_t SBBR_PERF_SERVER  = 7;
 
-	fwts_log_info(fw, "FADT Preferred PM Profile: %hhu (%s)\n",
+	fwts_log_info(fw, "FADT Preferred PM Profile: %hhu (%s)",
 		fadt->preferred_pm_profile,
 		FWTS_ACPI_FADT_PREFERRED_PM_PROFILE(fadt->preferred_pm_profile));
 
-- 
2.17.1




More information about the fwts-devel mailing list