ACK: [PATCH 2/2] uefi: uefivarinfo: add to UNSAFE category

Colin Ian King colin.king at canonical.com
Tue Aug 7 11:24:40 UTC 2018


On 07/08/18 12:18, Ivan Hu wrote:
> uefivarinfo actually call to runtime services provided by UEFI firmware to
> get the variable infomation. It should be on UNSAFE category.
> 
> Signed-off-by: Ivan Hu <ivan.hu at canonical.com>
> ---
>  src/uefi/uefivarinfo/uefivarinfo.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/uefi/uefivarinfo/uefivarinfo.c b/src/uefi/uefivarinfo/uefivarinfo.c
> index a54a636..58b8f68 100644
> --- a/src/uefi/uefivarinfo/uefivarinfo.c
> +++ b/src/uefi/uefivarinfo/uefivarinfo.c
> @@ -253,6 +253,6 @@ static fwts_framework_ops uefivarinfo_ops = {
>  	.minor_tests = uefivarinfo_tests
>  };
>  
> -FWTS_REGISTER("uefivarinfo", &uefivarinfo_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_UTILS | FWTS_FLAG_ROOT_PRIV)
> +FWTS_REGISTER("uefivarinfo", &uefivarinfo_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_UTILS | FWTS_FLAG_UNSAFE | FWTS_FLAG_ROOT_PRIV)
>  
>  #endif
> 

Seems like a very good idea to mark it unsafe.

Acked-by: Colin Ian King <colin.king at canonical.com>



More information about the fwts-devel mailing list